refactor server response code #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend the FtpConnection prototype to add a 'respond' method Not only does this make the code lighter and more maintainable, but it also resolves an ambiguous socket reference.
addrummond
added a commit
that referenced
this pull request
Jan 25, 2014
refactor server response code
asylumfunk
added a commit
to asylumfunk/nodeftpd
that referenced
this pull request
Mar 7, 2014
This string previously contained a <CRLF> sequence, when commands were still writing directly to the socket. ref nodeftpd#2 ref 22c8d17
mk-pmb
pushed a commit
to mk-pmb/nodeftpd
that referenced
this pull request
Feb 5, 2021
mk-pmb
pushed a commit
to mk-pmb/nodeftpd
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend the FtpConnection prototype to add a 'respond' method
make the code lighter and more maintainable
resolve an ambiguous socket reference.
fix asylumfunk#2
prevent asylumfunk#1