Better logging #91
Open
Better logging #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75a6ce4 to
94ebd46
Compare
Collaborator
|
Hi @oleksiyk. Thanks for this work on logging! I'm in the process of a big refactor using ES6 and adding a better abstraction around active/passive data connections. I can take a closer look at this diff soon and possibly merge it into master, but I think the new branch will actually become the master branch in the near future, so we may need to manually add this feature to that branch at some point. |
Contributor
Author
|
Hi Simon! |
Collaborator
|
No, not dropping support for v0.10. I'll continue to support all the versions we support now. The ES6 features will be transformed to valid ES5 before publishing to NPM. |
Contributor
Author
|
Ok, let me know what you decide. I will adapt this one for ES6 branch or create new PR. |
94ebd46 to
09016d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes nodeftpd to log messages like this:
Each message consists of 5 space separated fields:
Messages are logged in color to TTY and without any color escape sequences when stdout/stderr is redirected to file.
Several new options added:
ttyColors: boolean, set tofalseto force disable coloured outputlogFunction: function, overwrite default function used to log messages. Receives 4 arguments: level, remote ip, authenticated user, message.logLeveloption remains the same: from 0 (just errors) to 4 (trace)I've also used sinon to verify logged messages in some tests instead of old method:
oleksiyk@df873e5#diff-51ecdc1506ecf5aaebb57c019653fbe6L124
Logging level can also be redefined with NODEFTPD_LOG_LEVEL environment variable.