-
Notifications
You must be signed in to change notification settings - Fork 697
Bump libgit2 to a preview of v0.28 #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
implausible
merged 8 commits into
nodegit:master
from
implausible:bump/libgit2-preview-v0.28
Jan 29, 2019
Merged
Bump libgit2 to a preview of v0.28 #1615
implausible
merged 8 commits into
nodegit:master
from
implausible:bump/libgit2-preview-v0.28
Jan 29, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added git_index_name_entry - Added git_index_reuc_entry - Added git_mailmap - Added git_path_is_gitfile
certificateCheck used to require passing 1 to ignore certificate failures. Now we need to pass 0 to inform libgit2 that the certificate was deemed valid.
There is something spooky in git_stash_save on OSX only. |
2172a65
to
c363ca3
Compare
Looks like it wasn't a segfault, but test pollution from |
c363ca3
to
f41c963
Compare
As a follow up to this:
|
emmax86
approved these changes
Jan 29, 2019
cc03ba8
to
05fd145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to address the many incoming deprecations from Libgit2. It also handles a lot of the additional features Libgit2 has exposed since 0.27.0
This release also improves some of our capacity to handle code generation for statically allocated arrays as needed for
git_index_reuc_entry
. Check out the field mode and oid on git_index_reuc_entry here https://libgit2.org/libgit2/#HEAD/type/git_index_reuc_entry.This PR also changes GitBuf.prototype.set and GitBuf.prototype.grow to sync.