Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

emmax86
Copy link
Collaborator

@emmax86 emmax86 commented Feb 1, 2019

  1. Enhancement to the Repository.prototype.continueRebase method which allows a RebaseOptions to be passed in. This achieves parity with Repository.prototype.rebaseBranches.

  2. Also introduces a breaking change from the error handling pattern introduced to continueRebase in BREAKING: Convert sync methods to async methods #1348. Previously, all errors which occurred in the middle of a continueRebase operation would be swallowed. However, the introduction of signingCb as a field on RebaseOptions shed light on legitimate use cases where continueRebase should throw. My solution was to swallow the EAPPLIED error (specifically mentioned in the review of BREAKING: Convert sync methods to async methods #1348) and throw all others.

One example of a meaningful exception occurring in `continueRebase` is for the signing callback to throw because of an invalid key passphrase. In such chases, errors should not be swallowed.

In nodegit#1348, EAPPLIED was mentioned specifically as en error that we would like to swallow.
@emmax86 emmax86 self-assigned this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants