Remove promisify-node and remove old callback api remnants #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get rid of the nodegit-promise library, because the promise spec is basically complete in Node on all LTS versions of Node. I think the last holdup was
.finally, and that's officially in node 10 and above https://node.green/#ES2018-features-Promise-prototype-finallyThis shouldn't break anything at all...
Interesting thing to note, we basically promisify every function 1 by 1 after the nodegit.js template gets hydrated. We also don't write node-callback style functions in our
libfolder anymore. So that means thepromisify(exports)function that we wrote should no longer be necessary in the nodegit.js template.