Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add VCToolsVersion for msvs #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 2 commits into from
Oct 18, 2023
Merged

feat: add VCToolsVersion for msvs #209

cclauss merged 2 commits into from
Oct 18, 2023

Conversation

@tr-takatsuka
Copy link
Contributor

@tr-takatsuka tr-takatsuka commented Oct 11, 2023

Add the ability to specify the 'MSVC toolset version' for the VisualStudio platform.

This PR created for gyp-next, following the adviced in node-gyp. Thank you.
nodejs/node-gyp#2910

Usage example for binding.gyp

'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",

Thank you and best regards.

@tr-takatsuka
Add the ability to specify the 'MSVC toolset version' <VCToolsVersion…
d2c5c8c 
…> for the VisualStudio platform.

Usage example for binding.gyp

```
'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",
```
@cclauss
Copy link
Contributor

cclauss commented Oct 11, 2023 •
edited
Loading

@StefanStojanovic @rzhao271 Your reviews, please.

@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Oct 11, 2023

I see a problem with this PR, and all future PRs in this repo unrelated to changes directly. The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019. However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022. Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest. We could do this in another PR, land it and after that rebase this one, or directly in this PR. Although first approach would be cleaner I do not have any objections to doing it in here.

rzhao271
rzhao271 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tr-takatsuka
chore: update build-windows runs-on to windows-latest
162b4d8 
extract from comments by PR nodejs#209:add VCToolsVersion for msvs
```
The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019.
However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022.
Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest.
```
@tr-takatsuka
Copy link
Contributor Author

tr-takatsuka commented Oct 12, 2023

Thanks for the review.

I think I have understood your points correctly.
changed build-windows workflow to "windows-latest".
could you review if this change is correct?

@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Oct 12, 2023

Thank you @tr-takatsuka. Yes you understood me correctly. @cclauss in this repo I do not have a write access, so can you please approve changes to trigger the workflows?

@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Oct 18, 2023

Is there something more that should be done with this PR? I think it can land cc @cclauss

cclauss
cclauss approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@cclauss cclauss merged commit 0e35ab8 into nodejs:main Oct 18, 2023
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
This was referenced Oct 18, 2023
Closed
Closed
@tr-takatsuka tr-takatsuka deleted the add_vctoolsversion branch October 19, 2023 00:47
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@cclauss cclauss cclauss approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@joaocgreis joaocgreis Awaiting requested review from joaocgreis

@gengjiawen gengjiawen Awaiting requested review from gengjiawen

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

+1 more reviewer

@rzhao271 rzhao271 rzhao271 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tr-takatsuka @cclauss @StefanStojanovic @targos @rzhao271