Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove semver dependency #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

remove semver dependency #281

merged 1 commit into from
Jan 30, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 30, 2024

replace the necessity to load semver by using a regex instead. Actually just doing

const [major, minor, patch] = pkg.version.split('.')

would have been enough. But I think the regex is better.

ShogunPanda
ShogunPanda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given I don't think we're going to ever have exotic package version, I think this is already enough. Let's go!

@ShogunPanda ShogunPanda merged commit 9d58799 into nodejs:main Jan 30, 2024
@Uzlopak Uzlopak deleted the remove-semver branch January 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @ShogunPanda