Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Arlen-LT
Copy link
Contributor

Description:
This pull request ensures that shared libraries on DLL platforms are installed correctly into ${CMAKE_INSTALL_BINDIR}. According to the CMake documentation on Runtime Output Artifacts and Library Output Artifacts:

On DLL platforms: the executable file (e.g. .dll) of a shared library target created by the add_library() command with the SHARED option.
On non-DLL platforms: the shared library file (e.g. .so or .dylib) of a shared library target created by the add_library() command with the SHARED option.

Problem:
Previously, the installation location of shared libraries on DLL platforms is ignored since RUNTIME DESTINATION not defined.

@ShogunPanda ShogunPanda merged commit 905220f into nodejs:main May 31, 2024
@Arlen-LT Arlen-LT deleted the fix-cmake-install-for-windows branch June 12, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants