Conversation
Trott
reviewed
Jan 13, 2017
Member
There was a problem hiding this comment.
typo? Seems like it should be || instead of |?
Member
Author
There was a problem hiding this comment.
Oops... It is a typo. Thanks!
hiroppy
force-pushed
the
feature/add-tests-to-test-fs-open-flags.js
branch
from
January 13, 2017 05:09
ea9f7f4 to
211358c
Compare
jasnell
approved these changes
Jan 13, 2017
cjihrig
approved these changes
Jan 13, 2017
sam-github
suggested changes
Jan 13, 2017
Contributor
There was a problem hiding this comment.
please put after r+, so that the asserts are in documentation order, making it much easier to check that all documented flags are tested.
Also, I notice that your test for sr+, but that is not documented, but neither are xw, etc, which are also tested here.
I'll document the combinations, unless you are interested in PRing a doc update as well?
Member
Author
There was a problem hiding this comment.
Updated.
I'll update a doc:) Maybe it is here?
hiroppy
force-pushed
the
feature/add-tests-to-test-fs-open-flags.js
branch
from
January 13, 2017 20:35
211358c to
103397a
Compare
hiroppy
force-pushed
the
feature/add-tests-to-test-fs-open-flags.js
branch
from
January 13, 2017 20:36
103397a to
0d87817
Compare
Member
|
@sam-github does this LGTY now? |
sam-github
approved these changes
Jan 16, 2017
Member
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2017
PR-URL: #10780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
|
Landed in 622b439 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
|
This will need backport PRs in order to land on v6 or v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the test of line 35, 36.
https://github.com/nodejs/node/blob/master/lib/internal/fs.js#L35
https://github.com/nodejs/node/blob/master/lib/internal/fs.js#L36
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test