Conversation
Member
|
LGTM, but I prefer the commit message to be a tad mellower, since some dictionaries do consider "misformatted" a word. |
jsumners
force-pushed
the
misformatted
branch
from
February 23, 2017 17:42
b88382f to
010cf9d
Compare
Contributor
Author
|
@TimothyGu I have updated the commit message. |
jasnell
approved these changes
Feb 23, 2017
TimothyGu
approved these changes
Feb 23, 2017
cjihrig
approved these changes
Feb 24, 2017
Member
|
If everyone feels good about |
Contributor
Author
|
I had not seen that documentation in |
Member
|
Going to land this, we can make further changes in a separate PR |
jasnell
pushed a commit
that referenced
this pull request
Mar 1, 2017
PR-URL: #11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
Landed in a520508 |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
PR-URL: #11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
PR-URL: #11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates documentation included in the new well-known CAs feature to change the word "misformatted" to "malformed" since the word "misformatted" is less common.
Checklist
Affected core subsystem(s)
doc