Thanks to visit codestin.com
Credit goes to github.com

Skip to content

src: emit warnings from V8 - #24365

Merged
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:feature/v8-warnings
Nov 16, 2018
Merged

src: emit warnings from V8#24365
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:feature/v8-warnings

Conversation

@devsnek

@devsnek devsnek commented Nov 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Currently the only place V8 does this is asm.js compilation:

function AsmModule() {
  'use asm';

  function add(a, b) {
    a = a | 0;
    b = b | 0;

    // should be `return (a + b) | 0;`
    return a + b; // (node:18940) V8: test.js:9 Invalid asm.js: Invalid return type
  }

  return { add: add };
}

In chromium:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1610/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 14, 2018
@devsnek devsnek added the v8 engine Issues and PRs related to the V8 dependency. label Nov 14, 2018
@devsnek
devsnek requested review from addaleax and hashseed November 14, 2018 15:11
@targos

targos commented Nov 14, 2018

Copy link
Copy Markdown
Member

Is it testable? Maybe with a message test?

addaleax
addaleax reviewed Nov 14, 2018
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the test case from the PR description as a test here?

Comment thread src/node.cc Outdated
@devsnek
devsnek force-pushed the feature/v8-warnings branch from 2375408 to 94e10db Compare November 14, 2018 15:28
@devsnek

devsnek commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

@targos @addaleax tests added 👍

@devsnek

devsnek commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/18610/

refack
refack reviewed Nov 14, 2018
View reviewed changes

@refack refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/node.cc Outdated
Comment thread src/node.cc Outdated
@refack refack added the wasm Issues and PRs related to WebAssembly. label Nov 14, 2018
@devsnek devsnek removed the wasm Issues and PRs related to WebAssembly. label Nov 14, 2018
@refack

refack commented Nov 14, 2018

Copy link
Copy Markdown
Contributor

refack added the wasm label

I know it's not wasm but it's the most relevant label.

@devsnek devsnek added the asm.js label Nov 14, 2018
joyeecheung
joyeecheung approved these changes Nov 14, 2018
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be even better if ProcessEmitWarningGeneric is less generic on the C++ side and we can just do the overload in JS...but anyway LGTM

(off-topic: we have a wasm label? AND a asm.js label? and they are both green?)

thefourtheye
thefourtheye approved these changes Nov 14, 2018
View reviewed changes
Comment thread src/node.cc Outdated
@refack

refack commented Nov 14, 2018

Copy link
Copy Markdown
Contributor

a wasm label? AND a asm.js label? and they are both green

The asm.js is brand new. And like their subjects, if you look from a distance they look the same ;)

@devsnek
devsnek force-pushed the feature/v8-warnings branch from 94e10db to 6a17bd4 Compare November 14, 2018 18:40
bnoordhuis
bnoordhuis reviewed Nov 14, 2018
View reviewed changes
Comment thread src/node.cc Outdated
Comment thread src/node.cc Outdated
Comment thread src/node.cc Outdated
Comment thread src/node.cc Outdated
@devsnek
devsnek force-pushed the feature/v8-warnings branch from 6a17bd4 to fc4ec7a Compare November 14, 2018 20:05
@devsnek

devsnek commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/18619/

@devsnek
src: emit warnings from V8
e1aa730 
PR-URL: nodejs#24365
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@devsnek
devsnek force-pushed the feature/v8-warnings branch from fc4ec7a to e1aa730 Compare November 16, 2018 15:18
@devsnek
devsnek merged commit e1aa730 into nodejs:master Nov 16, 2018
@devsnek
devsnek deleted the feature/v8-warnings branch November 16, 2018 15:19
targos pushed a commit that referenced this pull request Nov 18, 2018
@devsnek @targos
src: emit warnings from V8
ece2a7a 
PR-URL: #24365
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@devsnek @rvagg
src: emit warnings from V8
5d67eec 
PR-URL: #24365
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@codebytere

codebytere commented Jan 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@devsnek do you think that this can/should be backported to v10.x? I added the label but feel free to remove!

This was referenced May 21, 2026
Closed
Merged
@Renegade334 Renegade334 mentioned this pull request May 21, 2026
Closed
nodejs-github-bot pushed a commit that referenced this pull request May 25, 2026
@joyeecheung
test: remove test-node-output-v8-warning
e2ad744 
asm.js validation is deprecated and disabled by default in V8,
so there's no longer a stable user-reachable trigger for
`v8::Isolate::kMessageWarning`. Remove the test.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184

Signed-off-by: Joyee Cheung <[email protected]>
PR-URL: #63469
Fixes: nodejs/node-v8#310
Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request May 27, 2026
@joyeecheung @aduh95
test: remove test-node-output-v8-warning
0c9c523 
asm.js validation is deprecated and disabled by default in V8,
so there's no longer a stable user-reachable trigger for
`v8::Isolate::kMessageWarning`. Remove the test.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184

Signed-off-by: Joyee Cheung <[email protected]>
PR-URL: #63469
Fixes: nodejs/node-v8#310
Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
sxa pushed a commit to sxa/node that referenced this pull request Jun 18, 2026
@joyeecheung @sxa
test: remove test-node-output-v8-warning
b01014f 
asm.js validation is deprecated and disabled by default in V8,
so there's no longer a stable user-reachable trigger for
`v8::Isolate::kMessageWarning`. Remove the test.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184

Signed-off-by: Joyee Cheung <[email protected]>
PR-URL: nodejs#63469
Fixes: nodejs/node-v8#310
Refs: https://issues.chromium.org/issues/510487707
Refs: nodejs#24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
sxa pushed a commit that referenced this pull request Jun 18, 2026
@joyeecheung @sxa
test: remove test-node-output-v8-warning
5e8ff22 
asm.js validation is deprecated and disabled by default in V8,
so there's no longer a stable user-reachable trigger for
`v8::Isolate::kMessageWarning`. Remove the test.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184

Signed-off-by: Joyee Cheung <[email protected]>
PR-URL: #63469
Fixes: nodejs/node-v8#310
Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@hashseed hashseed Awaiting requested review from hashseed
+2 more reviewers
@refack refack refack approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@devsnek @nodejs-github-bot @targos @refack @codebytere @bnoordhuis @thefourtheye @addaleax @cjihrig @joyeecheung