test: detect missing postmortem metadata #27828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
May 22, 2019
targos
approved these changes
May 22, 2019
jasnell
approved these changes
May 23, 2019
BridgeAR
approved these changes
May 23, 2019
Trott
approved these changes
May 25, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23332/ EDIT(cjihrig): CI was yellow (although I don't know if this tests runs as part of the CI anyway). |
This commit updates test-postmortem-metadata to provide a more useful error message in the scenario where Node is compiled without postmortem support. PR-URL: nodejs#27828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
This commit updates test-postmortem-metadata to provide a more useful error message in the scenario where Node is compiled without postmortem support. PR-URL: #27828 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates test-postmortem-metadata to provide a more useful error message in the scenario where Node is compiled without postmortem support.
Refs: #27375 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes