doc: fix some signatures of .end() methods #29615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `.end()` methods, an optional `encoding` parameter makes sense only if the `data` (`chunk`) parameter is provided.
devnexen
approved these changes
Sep 19, 2019
lpinca
approved these changes
Sep 19, 2019
trivikr
approved these changes
Sep 19, 2019
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
In `.end()` methods, an optional `encoding` parameter makes sense only if the `data` (`chunk`) parameter is provided. PR-URL: #29615 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in ab9b8e7 |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
In `.end()` methods, an optional `encoding` parameter makes sense only if the `data` (`chunk`) parameter is provided. PR-URL: #29615 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
In `.end()` methods, an optional `encoding` parameter makes sense only if the `data` (`chunk`) parameter is provided. PR-URL: #29615 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesIn
.end()methods, an optionalencodingparameter makes sense only if thedata(chunk) parameter is provided.