Conversation
Member
|
lgtm |
Member
|
LGTM |
Contributor
|
Ditto |
Contributor
|
LGTM |
Contributor
|
Can you please include the complete description in the PR to the commit log as well? |
It is required for using the "SIGABRT" constant. It doesn't cause compilation errors in Node because most files already have "signal.h" included, but it causes errors for third party embedder.
Contributor
Author
|
Sure, I have updated the commit message. |
Contributor
|
@zcbenz I am sorry, the commit log lines should not exceed 72 characters. Ref: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
Member
|
@thefourtheye you can fix this when you rebase to land the commit |
bnoordhuis
pushed a commit
that referenced
this pull request
Sep 25, 2015
It is required for using the "SIGABRT" constant. It doesn't cause compilation errors in Node because most files already have "signal.h" included, but it causes errors for third party embedder. PR-URL: #3058 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Member
|
Landed in 1b78151, thanks. It takes the cake for number of reviewers for a one-liner. :-) |
rvagg
pushed a commit
that referenced
this pull request
Sep 30, 2015
It is required for using the "SIGABRT" constant. It doesn't cause compilation errors in Node because most files already have "signal.h" included, but it causes errors for third party embedder. PR-URL: #3058 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
This was referenced Sep 30, 2015
This was referenced Sep 17, 2021
This was referenced Sep 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is required for using the
SIGABRTconstant.It doesn't cause compilation errors in Node because most files already have "signal.h" included, but it causes errors for third party embedder.