Codestin Search App

Trott · 2016-02-03T04:44:12Z

This change enables the es6 environment in eslint. Rather than selecting
es6 rules one at a time, this turns all of them on with the exception of
modules.

Ref: #5028

Not sure if this will be controversial or not. And not sure if it makes sense
to land on LTS or not. (Maybe we shouldn't use es6-isms not supported by
LTS? Certainly not for code that needs to land on LTS, of course. But I'm not
sure a lot of these rules will actually cover things that don't work in LTS but work
in Stable. Will have to look into that...)

This change enables the es6 environment in eslint. Rather than selecting es6 rules one at a time, this turns all of them on with the exception of modules. Ref: nodejs#5028

cjihrig · 2016-02-03T04:56:45Z

LGTM pending CI. This can probably be safely backported to LTS. It just enables parsing of the language features. Of course, we should verify it in CI first.

Trott · 2016-02-03T04:58:02Z

Turns out this is roughly equivalent to #5028 so it should be all good. Let's give CI a whirl...

https://ci.nodejs.org/job/node-test-pull-request/1522/

jbergstroem · 2016-02-03T04:58:54Z

Yeah I'm all for it as well; LGTM after CI turns green.

Trott · 2016-02-03T04:59:05Z

Also, adding lts-watch-v4.x based on @cjihrig comment.

jbergstroem · 2016-02-03T04:59:26Z

✅ https://ci.nodejs.org/job/node-test-linter/1213/

Trott · 2016-02-03T05:29:05Z

Unrelated failure with known-ish flaky test in CI that might be fixed if #4772 lands. But I like my CI's green, so I'm going to run it again:

https://ci.nodejs.org/job/node-test-pull-request/1523/

rvagg · 2016-02-03T08:29:08Z

The question about LTS suitability goes more to just this being able to be used on LTS, it's about what this enables on master that can't be done on LTS and therefore makes cherry-picking more difficult because it widens the gap between the branches.

I'm also wondering what this enables in core that our current config disallows? And, whether we actually want to accept usage of those features. I'd personally prefer to take a more strategic approach to adopting language features that's based on an understanding of performance and an assessment of how it might impact on the readability of our codebase. Already we have a really awkward state of flux, particularly around the transition from var to its newer offspring. Increased messiness (yes, a subjective measure), is likely going to impact on approachability for newcomers.

Our policy on evolutionary change of the codebase is also to blame for this current state of flux but there are good justifications for that.

So, pending hearing about what this enables that isn't already enabled by the current ruleset, I'm -0 on this. I'd also like this to hold off until @jasnell and @thealphanerd have a chance to weigh in on the question of the impact this is going to have on the difficulty of maintaining LTS.

cjihrig · 2016-02-03T13:01:26Z

@rvagg is your only objection toward LTS, or against this change in master? It would, most likely, be simple to get away with not backporting this to LTS, as we shouldn't be introducing any new language features. On master, I think this is a worthwhile change. ESLint is moving away from enabling specific language features. Once ESLint 2.0.0 is released, you are expected to enable a language version, not specific features.

EDIT: Another thing to consider is whether ESLint updates will be backported. If so, the existing config will need to change anyway.

jasnell · 2016-02-03T14:05:52Z

It's not so much about pulling this one change back. The key challenge is
that as more and more ES6 language features make their way into commits
landing in master, the harder it becomes to cherry pick and pull individual
commits back. The wider the gap between master and LTS becomes, the more
difficult it is. As we continue down the road further, we'll need people to
be more proactive about backporting their own commits, especially if they
make heavy use of new language features.
On Feb 3, 2016 5:01 AM, "Colin Ihrig" [email protected] wrote:

@rvagg https://github.com/rvagg is your only objection toward LTS, or
against this change in master? It would, most likely, be simple to get away
with not backporting this to LTS, as we shouldn't be introducing any new
language features. On master, I think this is a worthwhile change. ESLint
is moving away from enabling specific language features. Once ESLint 2.0.0
http://eslint.org/blog/2016/02/eslint-v2.0.0-rc.0-released#language-options
is released, you are expected to enable a language version, not specific
features.

—
Reply to this email directly or view it on GitHub
#5052 (comment).

cjihrig · 2016-02-03T14:33:28Z

@jasnell sorry, I was referring only to this PR. It doesn't introduce anything into the actual source code. It just makes ESLint more pleasant to deal with. People are certainly going to want these features enabled to experiment with new features in core (the original reason for #5028), even if they don't land. And, as I mentioned in the edit to my previous comment, ESLint is ditching ecmaFeatures, so a change like this will be required anywhere we plan to keep up with ESLint releases.

Trott · 2016-02-03T18:17:18Z

@thefourtheye You might want to re-open your PR and scale it back to just enabling the spread operator or whatever it was originally opened for. This one looks like it might get hung up for a while or not happen at all. A narrow conversation around the single feature you were originally trying to enable might go faster.

Trott · 2016-02-03T18:23:56Z

One thing to note is that, just like we can turn individual features on, we can also turn them off. I hesitate to endorse a deny-list approach over an allow-list approach in any context, there might be some value in making ecmaFeatures opt-out like this rather than opt-in. It will probably make understanding and managing the .eslintrc easier.

thefourtheye · 2016-02-03T19:14:35Z

@Trott I would prefer to wait till we reach a consensus before re-opening that PR :-) If at all possible, we ll do it in this PR's way.

Trott · 2016-02-03T19:26:49Z

@rvagg asked:

I'm also wondering what this enables in core that our current config disallows?

Here are the features that this PR enables that we do not currently have enabled. Reminder that we can turn any of them off individually if we wish.

regexUFlag: enable the regular expression u flag
regexYFlag: enable the regular expression y flag
unicodeCodePointEscapes: enable code point escapes
superInFunctions: enable super references inside of functions
defaultParams: enable default function parameters
restParams: enable rest parameters
objectLiteralComputedProperties: enable computed object literal property names
objectLiteralDuplicateProperties: enable duplicate object literal properties in strict mode
destructuring: enable destructuring
spread: enable the spread operator for arrays
newTarget: allows you to use new.target in your code

I opened this PR because that list is almost identical to the list that was proposed for being added/enabled in #5028. The only difference is this adds newTarget as well (which is removed in subsequent versions of eslint and appears to just be on if you turn on ES6 in those later versions).

Trott · 2016-02-03T19:28:10Z

@thefourtheye That works too. If there's a need or desire for just the spread operator, though, that conversation might go faster. And there's no reason that other PR can't go through with just the spread operator, and then this one comes along at a later date. But if you'd rather wait and see what happens here, that's fine by me too.

rvagg · 2016-02-04T11:46:29Z

Thanks for the list @Trott, perfect.

So there are two issues here, not necessarily blockers mind you:

As both @jasnell and I have tried to articulate, code churn that relates to the adoption of new language and V8-specific features that are not possible to use, or are suboptimal to use in older versions of V8 as maintained in LTS branches will make LTS maintenance increasingly difficult because of the difficulty involved in cherry-picking. This is not about cherry-picking those changes, it's about the fact that the patch process requires context in order to figure out which lines need to be changed. When the context is different, the patches fail. So a => in place of a function on a line completely unrelated to a change being cherry-picked but close enough to appear on a patch, will cause the cherry-pick to fail. The most likely outcome of this is not that LTS maintainers will work harder, it's that they will ration their work and LTS lines will go stale much quicker, like 0.12 is now because it's so far from any newer active branch. So the motivation here is primarily about ensuring that it's easier to keep an LTS line actively pulling in changes for a longer period of time. Secondarily it's about making life easier for those of us who care about those branches (@thealphanerd is shouldering a lot of that burden atm). Imagine for a moment that arrow functions didn't make it in to v4 (they nearly didn't). The cherry-pick difficulty would be pretty big.
A language feature's availability does not necessarily mean it should be used in core, for a number of reasons:
a. We need to find agreement on whether we as a group are OK with even using said feature, it's not acceptable to bulldoze ahead just because a feature is available, as we are consensus-seeking it's the responsibility to those advocating for a new feature to ensure that they have broad agreement, or more specifically, no disagreement.
b. Performance; as we have seen with many new features in V8, the priority initially is to get the feature correct in V8 and then do perf tuning as a later pass.
c. Readability, grokability, and other more difficult to measure things that go to accessibility and maintainability of our codebase. We could also include documentation in this as many people look to core for help on deciding on ideal style, particularly people new to Node.js. Yay bikesheds.

So far the track record has been pretty positive I think on adopting features. We've been careful and measured about it, conscious of performance and diff noise. So enthusiasts of new language features ought not to be pessimistic in light of item 2 above.

What I'm arguing for here is more of a gating process. If you want to use a new feature, like spread, then we should have a discussion about spread and bring to bear all of the concerns I've listed above. Perhaps spread has terrible performance and should be generally avoided? Perhaps the feature is not on LTS, we should involve LTS folks so they can think through what might happen if said feature started replacing large amounts of code over a short period of time, like let and const have done.

Lastly, there's also a question of style. Consider the recent discussion about arrow-function style, it's not just about enabling a feature but often about the particular style for how you use that feature. If we go ahead and enable a feature then we should apply a consistent style instead of letting different style variants be used and then later have clean-up commits (like we had with single-arg arrow-functions). That discussion can be had when we consider the individual feature.

My preference. So a soft -1 from me, i.e. happy to be overruled here if nobody agrees and I'm the only -1.

cjihrig · 2016-02-04T13:27:24Z

A language feature's availability does not necessarily mean it should be used in core

Enabling ESLint to not choke on a language feature is not a green light to use it in core. I agree that we still need to gate things. That is what the PR process is for. This doesn't introduce code into core just allows the tooling to be more flexible moving forward.

My second point is about ESLint itself. In the past we have cherry-picked ESLint updates back to at least v4.x. When/if that happens with the upcoming ESLint 2.0, we will have to do something similar to this anyway.

thefourtheye · 2016-02-04T13:29:08Z

That brings up the question, is performance the only criteria to decide if a feature should be allowed in core?

Trott · 2016-02-04T17:27:04Z

@rvagg Thanks for articulating the concerns in a clear and detailed fashion. Happy to say that nothing in there is surprising. Especially if @jasnell, @thealphanerd, or someone else has LTS concerns about this, I'm happy to go with their judgment.

I do want to reiterate @cjihrig's point, though, that this is not supposed to be a green light to start using all of these features. Nonetheless, I can also see how it will be difficult to prevent people from interpreting it that way. And you can certainly make the argument that it is unfriendly to new contributors for the linter to be more lax than what we actually want people to submit.

I'm actually +1 on opening separate PRs for each ES6 feature that people want to start using and having separate discussions for each one. I only opened this because #5028 was going to do nearly exactly the same thing as this PR and it had amassed several LGTMs including one from @jasnell. This is just a cleaner/shorter way to do it in the .eslintrc. If there's consensus on the one-at-a-time approach, we can close this, revert #5028 to just be the spread operator, and have the spread operator conversation there. And anyone interested in any of the other features listed above can open PRs for those.

Obligatory irony note: If I had not opened this PR, all these features would probably be enabled already (because #5028 probably would have sailed through--it already had 5 LGTMs).

Fishrock123 · 2016-02-04T21:09:32Z

objectLiteralDuplicateProperties

This seems like a bad idea, we should make sure this is off.

Trott · 2016-02-05T21:54:56Z

@thefourtheye What do you think of going back and having the spread discussion in #5028? This is stalling out and I'd like to close it unless someone wishes to vigorously champion it? _{…sideways glance at @cjihrig…}

rvagg · 2016-02-08T05:31:06Z

@cjihrig my response to:

Enabling ESLint to not choke on a language feature is not a green light to use it in core. I agree that we still need to gate things. That is what the PR process is for.

Was actually answered in an illustrative way by @Trott:

Obligatory irony note: If I had not opened this PR, all these features would probably be enabled already (because #5028 probably would have sailed through--it already had 5 LGTMs).

Due to the speed of dev around here I'm pretty sure none of us is reviewing 100% of the changes going in to core. Each change has an isolated group of people reviewing it, mostly a group who have rough interest in the area of concern. So my argument here is for the gating process to be more along the lines of: "doh! the linter is complaining at me, Node really should allow me to use <feature X>, I'm going to pull request that change", followed by a discussion amongst the interest groups that are concerned with language features, code readability, documentation, LTS, performance and other things that may be impacted by allowing that new feature.

mhdawson · 2016-02-08T21:41:04Z

My thinking is along the lines outlined by @rvagg. Having the discussion and enabling them one by one is probably the best way to ensure the right discussion/review occurs.

jasnell · 2016-02-08T21:53:54Z

At this point I'm -1 to enabling this. I'd rather see each rule enabled one at a time as needed.

Trott · 2016-02-08T22:11:06Z

Sounds like this can be closed and, if necessary, the spread operator can be discussed in #5028 or elsewhere.

Original commit message: unix: fix pedantic compiler warnings (#5052) Fixes: libuv/libuv#5051 Fixes: #63196 Refs: libuv/libuv#5052 Refs: libuv/libuv@a43e543 PR-URL: #63222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: René <[email protected]>

Original commit message: unix: fix pedantic compiler warnings (nodejs#5052) Fixes: libuv/libuv#5051 Fixes: nodejs#63196 Refs: libuv/libuv#5052 Refs: libuv/libuv@a43e543 PR-URL: nodejs#63222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: René <[email protected]>

Original commit message: unix: fix pedantic compiler warnings (#5052) Fixes: libuv/libuv#5051 Fixes: #63196 Refs: libuv/libuv#5052 Refs: libuv/libuv@a43e543 PR-URL: #63222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: René <[email protected]>

* stream: copyedit `webstreams/adapter.js` - Simplify `ZLIB_FAILURES` creation. - Cache `cause.code` in `handleKnownInternalErrors` in case of a getter. - Replace `SafePromiseAll` with `SafePromiseAllReturnVoid` to reduce the number of allocated promises. Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63034 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> * build: track PDL files as inputs in inspector GN build The `node_protocol_generated_sources` action was missing `gypi_values.node_pdl_files` from its inputs, causing Ninja to skip regeneration when PDL domain files changed. PR-URL: https://github.com/nodejs/node/pull/62888 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> * tools: use LTS Node.js in notify-on-push workflow Without pinning Node.js, the runner defaults to Node 20 and npx falls back to [email protected] instead of 6.0.0 (requires Node 22+). Version 5 does not recognise the ffi subsystem, causing false invalid-commit alerts. Signed-off-by: Nenad Spasenic <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63084 Fixes: https://github.com/nodejs/node/issues/63070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> * deps: update amaro to 1.1.9 PR-URL: https://github.com/nodejs/node/pull/63090 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * test_runner: fix failing suite hooks when marked with `todo` Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63097 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> * doc: fix the TypeScript Execute (tsx) project link Signed-off-by: David Thornton <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63093 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: René <[email protected]> * quic: start re-enabling quic with openssl 3.5 Start working on re-enabling QUIC support with the availability of OpenSSL 3.5. This will be a multi-step process. Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59249 Reviewed-By: Matteo Collina <[email protected]> * deps: update ngtcp2 to 1.14.0 Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59249 Reviewed-By: Matteo Collina <[email protected]> * deps: update nghttp3 to 1.11.0 Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59249 Reviewed-By: Matteo Collina <[email protected]> * quic: update the guard to check openssl version Since we need to be able to use the openssl adapter provided by the ngtcp2 library, and because that adapter does not include any compile guards to ensure that OpenSSL 3.5 is being used and that the APIs are actually available, we need to add a compile time check for the openssl version in order to conditionally include the adapter to avoid build errors when using a shared openssl library that is not OpenSSL 3.5. Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59249 Reviewed-By: Matteo Collina <[email protected]> * quic: fixup windows coverage compile error PR-URL: https://github.com/nodejs/node/pull/59381 Fixes: https://github.com/nodejs/node/issues/59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> * quic: fixup NO_ERROR macro conflict on windows PR-URL: https://github.com/nodejs/node/pull/59381 Fixes: https://github.com/nodejs/node/issues/59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> * quic: few additional small comment edits in cid.h Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> * quic: update more of the quic to the new compile guard Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> * quic: multiple fixups and updates Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> * quic: reduce boilerplate and other minor cleanups While I get that macros aren't the most loved thing in the world, they do help reduce boilerplate, and there's a lot of boilerplate in the QUIC code. This commit cleans up some of that boilerplate, particularly around the use of v8 APIs. PR-URL: https://github.com/nodejs/node/pull/59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> * src: cleanup quic TransportParams class PR-URL: https://github.com/nodejs/node/pull/59884 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Tim Perry <[email protected]> * src: fix small compile warning in quic/streams.cc Fixes: https://github.com/nodejs/node/issues/60110 PR-URL: https://github.com/nodejs/node/pull/60118 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> * deps: update nghttp3 to 1.13.1 PR-URL: https://github.com/nodejs/node/pull/60046 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * deps: update nghttp3 to 1.14.0 PR-URL: https://github.com/nodejs/node/pull/61187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * quic: copy options.certs buffer instead of detaching The certs could be allocated in a pooled buffer, like `Buffer.from`, and `Buffer.allocUnsafe` (used by `fs.readFileSync`, etc). PR-URL: https://github.com/nodejs/node/pull/61403 Refs: https://github.com/nodejs/node/pull/61372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> * quic: fix a handful of bugs and missing functionality Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62387 Reviewed-By: Stephen Belanger <[email protected]> * quic: update http3 impl details Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62387 Reviewed-By: Stephen Belanger <[email protected]> * quic: fixup linting/formatting issues Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode/Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62387 Reviewed-By: Stephen Belanger <[email protected]> * quic: use arena allocation for packets Previously Packets were ReqWrap objects with a shared free-list. This commit changes to a per-Endpoint arena with no v8 involvement. This is the design I originally had in mind but I initially went with the simpler freelist approach to get something working. There's too much overhead in the reqrap/freelist approach and individual packets do not really need to be observable via async hooks. This design should eliminate the risk of memory fragmentation and eliminate a significant bottleneck in the hot path. Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62589 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> * quic: move quic behind compile time flag Move node:quic behind a compile-time flag, disabled by default. Use --experimental-quic at configure time to enable. - Add --experimental-quic flag to configure.py - Add node_use_quic variable and HAVE_QUIC define - Make QUIC sources conditional in node.gyp - Move ngtcp2/nghttp3 deps under QUIC condition in node.gypi - Update C++ guards to check HAVE_QUIC - Update process.features.quic to check node_use_quic PR-URL: https://github.com/nodejs/node/pull/61444 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> * quic: implement rapidhash for hashing improvements Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62620 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tim Perry <[email protected]> * src: add permission support to config file PR-URL: https://github.com/nodejs/node/pull/60746 Backport-PR-URL: https://github.com/nodejs/node/pull/62760 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> * test: improve config-file permission test coverage Refs: https://github.com/nodejs/node/pull/60746#pullrequestreview-3470430664 PR-URL: https://github.com/nodejs/node/pull/60929 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * src: expose help texts into node-config-schema.json PR-URL: https://github.com/nodejs/node/pull/58680 Reviewed-By: Marco Ippolito <[email protected]> * test_runner: update node-config-schema PR-URL: https://github.com/nodejs/node/pull/58680 Reviewed-By: Marco Ippolito <[email protected]> * doc: fix node-config-schema PR-URL: https://github.com/nodejs/node/pull/61596 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * meta: bump actions/download-artifact from 8.0.0 to 8.0.1 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3...3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62549 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * quic: apply multiple TLS context improvements and SNI support Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62620 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tim Perry <[email protected]> * quic: support multiple ALPN negotiation Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62620 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tim Perry <[email protected]> * quic: fixup token verification to handle zero expiration Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/62620 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tim Perry <[email protected]> * util: colorize text with hex colors PR-URL: https://github.com/nodejs/node/pull/61556 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * quic: add QuicEndpoint.listening & QuicStream.destroy() and tests Starting to explore and cover the existing implementation, this covers the basic endpoint & stream lifecycle and the exposed properties. Added endpoint.listening to match net.Server and round out endpoint properties, and stream.destroy() which is already called by quicSession.destroy() and documented, but didn't actually exist. Signed-off-by: Tim Perry <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62648 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: James M Snell <[email protected]> * tools: add a check for clean git tree after tests Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62661 Refs: https://github.com/nodejs/node/issues/62646 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> * src: clean up experimental flag variables - `fetch` is no longer disable by a CLI flag - `node:sqlite` requires SQLite, obviously Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62759 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> * fs: add followSymlinks option to glob PR-URL: https://github.com/nodejs/node/pull/62695 Reviewed-By: Moshe Atlow <[email protected]> * doc: fix duplicate word "to to" in util.styleText PR-URL: https://github.com/nodejs/node/pull/62917 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> * test: update WPT for streams to f8f26a372f PR-URL: https://github.com/nodejs/node/pull/62864 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * test: update WPT for url to 258f285de0 PR-URL: https://github.com/nodejs/node/pull/63087 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> * repl: keep reference count for `process.on('newListener')` When investigating a memory leak in one of our applications, we discovered that this listener holds on to a `REPLServer` instance and all heap objects transitively kept alive by it by capturing as part of its closure. It's cleaner to declare the listener outside of the `REPLServer` class and to actually clean it up properly when it is no longer required or meaningful, which is easily achieved through keeping a reference count. PR-URL: https://github.com/nodejs/node/pull/61895 Backport-PR-URL: https://github.com/nodejs/node/pull/63194 Reviewed-By: Antoine du Hamel <[email protected]> * crypto: remove Argon2 KDF derivation from its job setup Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62863 Backport-PR-URL: https://github.com/nodejs/node/pull/63173 Fixes: https://github.com/nodejs/node/issues/62861 Reviewed-By: Antoine du Hamel <[email protected]> * crypto: reject unintended raw key format string input Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62974 Backport-PR-URL: https://github.com/nodejs/node/pull/63173 Reviewed-By: Antoine du Hamel <[email protected]> * doc: fix typos and inconsistencies in crypto.md and webcrypto.md Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62828 Backport-PR-URL: https://github.com/nodejs/node/pull/63173 Reviewed-By: Antoine du Hamel <[email protected]> * crypto: deduplicate and canonicalize CryptoKey usages Fixes: https://github.com/nodejs/node/issues/62899 Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62902 Backport-PR-URL: https://github.com/nodejs/node/pull/63173 Fixes: https://github.com/nodejs/node/issues/62899 Reviewed-By: Antoine du Hamel <[email protected]> * inspector: initial support storage inspection PR-URL: https://github.com/nodejs/node/pull/61139 Backport-PR-URL: https://github.com/nodejs/node/pull/63176 Reviewed-By: Antoine du Hamel <[email protected]> * inspector: auto collect webstorage data PR-URL: https://github.com/nodejs/node/pull/62145 Backport-PR-URL: https://github.com/nodejs/node/pull/63176 Reviewed-By: Antoine du Hamel <[email protected]> * inspector: return errors when CDP protocol event emission fails PR-URL: https://github.com/nodejs/node/pull/62162 Backport-PR-URL: https://github.com/nodejs/node/pull/63176 Reviewed-By: Antoine du Hamel <[email protected]> * inspector: coerce key and value to string in webstorage events Signed-off-by: Ali Hassan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62616 Backport-PR-URL: https://github.com/nodejs/node/pull/63176 Refs: https://github.com/nodejs/node/pull/62145 Refs: https://github.com/nodejs/node/pull/62162 Reviewed-By: Antoine du Hamel <[email protected]> * test: generate `localstorage.db` in a temp dir Co-Authored-By: Antoine du Hamel <[email protected]> Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62660 Backport-PR-URL: https://github.com/nodejs/node/pull/63176 Reviewed-By: Antoine du Hamel <[email protected]> * deps: V8: cherry-pick 657d8de27427 Original commit message: [maglev] Fix throwing node inside eager inlining This commit refactors the exception handling logic to correctly identify and associate nodes with their respective `catch` blocks, even when multiple levels of inlining are involved. Previously, the check `!IsInsideTryBlock() && !is_eager_inline()` was insufficient to determine if catch block inside `CatchDetails` was already created. Specifically, consider the case where: 1. Function `bar` is non-eagerly inlined into `foo`. 2. `foo` contains a `catch` block. 3. `bar` calls `in_bar`, which is eagerly inlined. 4. A node within `in_bar` can `throw`. In this scenario, `is_eager_inline` would be true when compiling `in_bar`, leading to an incorrect assumption that the catch block didn't exist yet. This change addresses the issue by propagating a boolean value via `CatchDetails`. This boolean accurately indicates whether a `catch` block is present in the call chain, allowing for correct exception handling regardless of inlining depth or eagerness. Fixed: 417768368 Change-Id: Ic52f72f302b4dc644bdcad939addf98111bc525b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6563500 Commit-Queue: Victor Gomes <[email protected]> Reviewed-by: Darius Mercadier <[email protected]> Cr-Commit-Position: refs/heads/main@{#100380} Refs: https://github.com/v8/v8/commit/657d8de274276c940d07203ee43d3cf4c732cebd PR-URL: https://github.com/nodejs/node/pull/62784 Reviewed-By: Xuguang Mei <[email protected]> * test_runner: support test order randomization PR-URL: https://github.com/nodejs/node/pull/61747 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> * test_runner: publish to TracingChannel for OTel instrumentation Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62502 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * test_runner: add `testId` to test events Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62772 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> * deps: update corepack to 0.35.0 PR-URL: https://github.com/nodejs/node/pull/63375 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> * 2026-05-21, Version 24.16.0 'Krypton' (LTS) Notable changes: crypto: * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) https://github.com/nodejs/node/pull/62553 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) https://github.com/nodejs/node/pull/62713 fs: * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) https://github.com/nodejs/node/pull/57775 * (SEMVER-MINOR) expose `frsize` field in `statfs` (Jinho Jang) https://github.com/nodejs/node/pull/62277 http: * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) https://github.com/nodejs/node/pull/63082 * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) https://github.com/nodejs/node/pull/62541 stream: * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) https://github.com/nodejs/node/pull/61098 test_runner: * (SEMVER-MINOR) support test order randomization (Pietro Marchini) https://github.com/nodejs/node/pull/61747 * (SEMVER-MINOR) align mock timeout api (sangwook) https://github.com/nodejs/node/pull/62820 * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) https://github.com/nodejs/node/pull/60751 util: * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) https://github.com/nodejs/node/pull/61556 PR-URL: https://github.com/nodejs/node/pull/63263 * Working on v24.16.1 PR-URL: https://github.com/nodejs/node/pull/63263 * deps: update undici to 7.28.0 PR-URL: https://github.com/nodejs/node/pull/63703 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * deps: fix aix implicit declaration in OpenSSL This seems like a bug in AIX header files because the examples show including the headers but upon inspecting these files there are no declarations for sendmmsg and others: https://www.ibm.com/docs/en/aix/7.2.0?topic=s-sendmmsg-subroutine For now we can claim to not have these functions. Alternatively we can declare these ourselves if we are AIX 7.2 or newer. The actual functions look to be available in libc. GCC also has the same implicit function declaration but it happily moves forward. Clang started making this an explict error in clang 16: https://www.redhat.com/en/blog/new-warnings-and-errors-clang-16 PR-URL: https://github.com/nodejs/node/pull/62656 Refs: https://www.ibm.com/docs/en/aix/7.2.0?topic=s-sendmmsg-subroutine Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> * deps: upgrade openssl sources to openssl-3.5.7 PR-URL: https://github.com/nodejs/node/pull/63820 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> * deps: update archs files for openssl-3.5.7 PR-URL: https://github.com/nodejs/node/pull/63820 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> * deps: update nghttp2 to 1.69.0 PR-URL: https://github.com/nodejs/node/pull/62891 Backport-PR-URL: https://github.com/nodejs/node/pull/63164 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> * deps: fix integration issues with the latest nghttp2 This is a set of src & tests fixes for nghttp2 due to changes in v1.67.0+ which require a selection of changes to how we handle low-level protocol errors when using the latest versions of nghttp2, changing both some src error handling and updating some tests to match. Signed-off-by: Tim Perry <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62891 Backport-PR-URL: https://github.com/nodejs/node/pull/63164 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Refs: https://hackerone.com/reports/3658225 CVE-ID: CVE-2026-48937 * deps: update llhttp to 9.4.2 PR-URL: https://github.com/nodejs-private/node-private/pull/890 Reviewed-By: Tobias Nießen <[email protected]> * lib,test: redact proxy credentials in tunnel errors Refs: https://hackerone.com/reports/3720313 Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs-private/node-private/pull/867 Reviewed-By: Joyee Cheung <[email protected]> CVE-ID: CVE-2026-48615 * permission: handle process.chdir on writereport Signed-off-by: RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs-private/node-private/pull/870 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48617 Refs: https://hackerone.com/reports/3625987 * tls: normalize hostname for server identity checks Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs-private/node-private/pull/869 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48618 Refs: https://hackerone.com/reports/3688064 * http2: cap originSet size to prevent unbounded memory growth A malicious HTTP/2 server can send repeated ORIGIN frames with unique origins, causing unbounded growth of the client-side originSet for the lifetime of the session. Cap the set at 128 entries; once full, new origins from ORIGIN frames are silently dropped. Refs: https://hackerone.com/reports/3676863 PR-URL: https://github.com/nodejs-private/node-private/pull/855 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48619 * tls: fix case-sensitive SNI context matching The regex constructed by server.addContext() lacked the case-insensitive flag, causing uppercase or mixed-case SNI hostnames from ClientHello to miss their intended context and fall back to the default context. This violates RFC 6066 Section 3, which states that DNS hostnames are case-insensitive. In mTLS configurations with per-tenant contexts, this allowed bypassing client certificate authorization by simply uppercasing the SNI hostname. Add the 'i' flag to the RegExp in addContext() so that SNI matching is case-insensitive. PR-URL: https://github.com/nodejs-private/node-private/pull/857 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48928 Refs: https://hackerone.com/reports/3656869 * dns,net: reject hostnames with embedded NUL bytes Ref: https://hackerone.com/reports/3656716 PR-URL: https://github.com/nodejs-private/node-private/pull/868 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48930 Refs: https://hackerone.com/reports/3656716 * permission: disable FileHandle utimes with permission model PR-URL: https://github.com/nodejs-private/node-private/pull/873 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48935 Refs: https://hackerone.com/reports/3625987 * http: fix response queue poisoning in http.Agent Attach a data guard listener on idle keepAlive sockets in the freeSockets pool. If unsolicited data arrives while the socket is idle, destroy it immediately to prevent response queue poisoning. Refs: https://hackerone.com/reports/3582376 PR-URL: https://github.com/nodejs-private/node-private/pull/846 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48931 Refs: https://hackerone.com/reports/3582376 * crypto: guard WebCrypto cipher output length Reject WebCrypto cipher operations whose computed output length would exceed INT_MAX before passing the length to OpenSSL. This avoids signed overflow in the AES and ChaCha20-Poly1305 one-shot cipher paths and turns oversized inputs into a clean operation failure. Refs: https://hackerone.com/reports/3760016 Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs-private/node-private/pull/878 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48933 * tls: bind reusable sessions to authenticated host Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/895 PR-URL: https://github.com/nodejs-private/node-private/pull/854 Reviewed-By: Antoine du Hamel <[email protected]> CVE-ID: CVE-2026-48934 Refs: https://hackerone.com/reports/3649802 * test: add session reuse host verification regressions Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/895 PR-URL: https://github.com/nodejs-private/node-private/pull/854 Reviewed-By: Antoine du Hamel <[email protected]> Refs: https://hackerone.com/reports/3649802 * 2026-06-18, Version 24.17.0 'Krypton' (LTS) This is a security release. Notable changes: * (CVE-2026-48618) tls: normalize hostname for server identity checks (Matteo Collina) – High * (CVE-2026-48933) crypto: guard WebCrypto cipher output length (Filip Skokan) – High * (CVE-2026-48615) lib,test: redact proxy credentials in tunnel errors (Matteo Collina) – Medium * (CVE-2026-48619) http2: cap originSet size to prevent unbounded memory growth (Matteo Collina) – Medium * (CVE-2026-48928) tls: fix case-sensitive SNI context matching (Matteo Collina) – Medium * (CVE-2026-48930) dns,net: reject hostnames with embedded NUL bytes (Matteo Collina) – Medium * (CVE-2026-48934) tls: bind reusable sessions to authenticated host (Matteo Collina) – Medium * (CVE-2026-48937) deps: fix integration issues with the latest nghttp2 – Medium * (CVE-2026-48617) permission: handle process.chdir on writereport (RafaelGSS) – Low * (CVE-2026-48931) http: fix response queue poisoning in http.Agent (Matteo Collina) – Low * (CVE-2026-48935) permission: disable FileHandle utimes with permission model (RafaelGSS) – Low PR-URL: https://github.com/nodejs-private/node-private/pull/899 * Working on v24.17.1 PR-URL: https://github.com/nodejs-private/node-private/pull/899 * doc: remove list of versions in `BUILDING.md` Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63113 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> * doc: document the latest-vX.x schema Signed-off-by: Marco Ippolito <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63033 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]> * doc: add Hmac.digest() documentation-only deprecation (DEP0206) Signed-off-by: anshikakalpana <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63121 Refs: https://github.com/nodejs/node/issues/62838 Reviewed-By: René <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]> * sqlite: keep source database alive during backup Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62673 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: James M Snell <[email protected]> * module: fix sync hook short-circuit in require() in imported CJS - For imported CJS, if it's not customized by asynchronous hooks, make sure it won't use the quirky re-invented require in all cases. - When the imported CJS module is customized by synchronous hooks, in the synthetic module evalutation step, avoid calling the respective default step again. - Make the branching of loadCJSModuleWithModuleLoad() and loadCJSModuleWithSpecialRequire() more explicit, and fold the tentative fs read in the 'commonjs' translator into the share createCJSModuleWrap() helper instead of checking it twice in the same path. Signed-off-by: Joyee Cheung <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62920 Fixes: https://github.com/nodejs/node/issues/63060 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> * test: use ERM to destroy sqlite database handles after tests Signed-off-by: Renegade334 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63076 Refs: https://github.com/nodejs/node/issues/63052 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Edy Silva <[email protected]> * doc,sqlite: document entryPoint argument for loadExtension Signed-off-by: geeksilva97 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63152 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> * doc: update release steps when post-release fails Signed-off-by: RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63131 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * tls: add unsupported renegotiation error Map BoringSSL's native renegotiation failure to ERR_TLS_RENEGOTIATION_UNSUPPORTED when TLSSocket#renegotiate() is called. This avoids exposing an implementation-specific OpenSSL error when the TLS backend does not support caller-initiated renegotiation. Signed-off-by: Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63161 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> * quic: remove unused binding variable in session.cc Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63177 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> * doc: clarify SEA platform support excludes darwin-x64 The Platform support section of the single-executable-applications doc listed `macOS` without qualifying which architecture is supported. SEA on x64 macOS is not supported and is skipped in CI; only arm64 macOS is exercised. Refs: https://github.com/nodejs/node/issues/62893 Signed-off-by: mokashang <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63181 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * doc: remove unnecessary `<!-- eslint-` magic comments Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63200 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> * meta: ignore AI assistants files Ignore CLAUDE.md and AGENTS.md in .gitignore, and exclude them from markdown and ESLint linting. Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> * lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array Follow WHATWG streams spec update: https://github.com/whatwg/streams/pull/1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: https://github.com/nodejs/node/issues/62952 Signed-off-by: Jah-yee <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63017 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Jason Zhang <[email protected]> * doc: add large pull requests contributing guide - Exclude routine dependency/WPT/bot PRs from the policy - Replace design document requirement with detailed PR description - Clarify dependency commit ordering for squash landing - Remove splitting strategies that contradict self-contained PRs - Add links from CONTRIBUTING.md, pull-requests.md, collaborator-guide.md Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62829 Fixes: https://github.com/nodejs/node/issues/62752 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> * tools: use different branch for tool updates on staging branches Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63110 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> * debugger: add --help to `node inspect` and improve docs - Add `--help` / `-h` to `node inspect` covering both interactive and non-interactive probe modes. The help text is printed when `--help`/`-h` appears before any positional argument to avoid hijacking `--help` passed to a child script. - Improve the documentation of probe mode and add examples, explain same-location probe coalescing, TDZ caveat for let/const bindings, basename matching and exit code behavior. Also move it to a section parallel to interactive mode. Remove recommendation of evaluating structured expressions as that is prone to missing info in JSON mode. Drive-by: When probe mode exits due to invalid arguments, exit with `kInvalidCommandLineArgument` (9) instead of `kGenericUserError` (1). Signed-off-by: Joyee Cheung <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63201 Reviewed-By: Jan Martin <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Aviv Keller <[email protected]> * deps: cherry-pick libuv/libuv@a43e543 Original commit message: unix: fix pedantic compiler warnings (#5052) Fixes: https://github.com/libuv/libuv/issues/5051 Fixes: https://github.com/nodejs/node/issues/63196 Refs: https://github.com/libuv/libuv/pull/5052 Refs: https://github.com/libuv/libuv/commit/a43e543dbffba93f014fe8360a5edbe8d6ce8500 PR-URL: https://github.com/nodejs/node/pull/63222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: René <[email protected]> * src,sqlite: remove dead code Signed-off-by: geeksilva97 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63204 Reviewed-By: René <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> * deps: V8: cherry-pick 435a2cdf664c Original commit message: [wasm] Update WebAssembly.Exception JS API WebIDL specifies the existence of a `WebAssembly.Exception.prototype.stack` getter. WebIDL also expects the constructor to have 2 parameters (plus an optional one). https://webassembly.github.io/spec/js-api/#exceptions Bug: 336347912, 42204334 Change-Id: I128e976a84f942dcf9b93a157534b15fad0f9215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7697976 Commit-Queue: Matthias Liedtke <[email protected]> Auto-Submit: Matthias Liedtke <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/main@{#106215} Refs: https://github.com/v8/v8/commit/435a2cdf664ce02e0c6ea9401fbae600663e47cb PR-URL: https://github.com/nodejs/node/pull/63136 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * crypto: improve system certificate enumeration logic on macOS 1) Fixed macOS default for missing kSecTrustSettingsResult When kSecTrustSettingsResult is absent from a trust settings dictionary, Apple specifies kSecTrustSettingsResultTrustRoot as the default value. Previously, the trust result evaluation (deny check, self-issued check, TrustAsRoot check) was inside the block that only executed when kSecTrustSettingsResult was explicitly present. When the key was absent, the function fell through to return UNSPECIFIED, incorrectly rejecting self-signed certificates that should have been trusted via the default. Move the trust result evaluation outside the conditional block so the default value of kSecTrustSettingsResultTrustRoot flows through the same code path as explicit values. This aligns with Chromium's trust_store_mac.cc implementation. 2) Fix CFRelease leak in IsTrustDictionaryTrustedForPolicy: the CFDictionaryRef returned by SecPolicyCopyProperties(policy_ref) was not released when the policy OID matched kSecPolicyAppleSSL. 3) Deduplicate certificates: SecItemCopyMatching can return the same certificate from multiple keychains. 4) Filter expired certificates. Signed-off-by: deepak1556 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62576 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> * doc: run license-builder PR-URL: https://github.com/nodejs/node/pull/63232 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> * lib: fixes validator message PR-URL: https://github.com/nodejs/node/pull/62823 Reviewed-By: Luigi Pinca <[email protected]> * lib: fix typo idenity => identity PR-URL: https://github.com/nodejs/node/pull/63112 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Aviv Keller <[email protected]> * node-api: support SharedArrayBuffer in napi_create_typedarray Signed-off-by: umuoy1 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62710 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> * meta: move one or more collaborators to emeritus PR-URL: https://github.com/nodejs/node/pull/63235 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> * doc: recommend explicitly Tier 1 or 2 for production applications Signed-off-by: Mike McCready <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63187 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * doc: replace Visual Studio 2022 Evergreen version reference with 17.14 Signed-off-by: Mike McCready <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63211 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> * test: move FFI tests to `NATIVE_SUITES` Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63165 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * doc: reference correct function in Module docs Signed-off-by: Robin Malfait <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63247 Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * tools: fix test426 updater The previous version produces a commit that does pass the linter because of a too-long commit title. Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63271 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * repl: fix dedup comparing normalized line against raw history Signed-off-by: Daijiro Wachi <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62886 Reviewed-By: Luigi Pinca <[email protected]> * test_runner: fix diagnostics channel context tracking Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63283 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> * http2: validate non-link headers in writeEarlyHints Validate header names and values for non-link hints passed to writeEarlyHints() in the HTTP/2 compat layer using assertValidHeader() and checkIsHttpToken(), consistent with the HTTP/1.1 validation added in https://github.com/nodejs/node/pull/61897. Previously, hints were forwarded into the headers object without any validation, allowing invalid characters in header names/values to surface as opaque errors deeper in the HTTP/2 stack. Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62017 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> * deps: update simdjson to 4.6.4 PR-URL: https://github.com/nodejs/node/pull/62811 Reviewed-By: Antoine du Hamel <[email protected]> * http: add writeInformation to send arbitrary 1xx status codes Signed-off-by: Tim Perry <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63155 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> * deps: update sqlite to 3.53.1 PR-URL: https://github.com/nodejs/node/pull/63217 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Jithil P Ponnan <[email protected]> * test: avoid initial-break wait in restart-message Signed-off-by: inoway46 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62060 Refs: https://github.com/nodejs/node/issues/61762 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> * test: avoid flaky restart sync in debugger exceptions test Signed-off-by: inoway46 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62055 Refs: https://github.com/nodejs/node/issues/61762 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> * stream: remove unnecessary check Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63030 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> * fs: make `Date` properties on `Stats` enumerable Signed-off-by: LiviaMedeiros <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63328 Reviewed-By: René <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * doc: remove inactive members from Triagers list Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63329 Fixes: https://github.com/nodejs/admin/issues/1058 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> * test: relax min assertion in test-performance-eventloopdelay Signed-off-by: marcopiraccini <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63100 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> * test_runner: avoid hanging on incomplete v8 frames Signed-off-by: Ali Hassan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62704 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * test: fix flaky test-watch-mode-inspect timeout This test randomly times out (~120s) on CI due to a race condition between child-process restart (triggered by touching the watched file) and the second inspector-session connection. The old code used an interval-based restart (write every 500ms) and a 'gettingDebuggedPid' flag to pause writes during a session. This still left a race window where getDebuggedPid() would attempt to connect the inspector via HTTP GET /json/list + WebSocket upgrade either before the new child was ready (empty target list) or after the old session was being destroyed, causing the promise to hang. Fix: Replace the interval with a single write that triggers exactly one restart, then wait for the restarted child's 'safe to debug now' stdout line before connecting the second inspector session. This eliminates the race by ensuring the new child process and its inspector session are fully ready before any connection attempt. Removes the now-unused gettingDebuggedPid flag and the pending setTimeout delay that was needed as a backstop for the interval. Fixes: https://github.com/nodejs/node/issues/44898 Signed-off-by: Matteo Collina <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63361 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> * test: reduce flakiness of `different-registry-per-thread` There was an assumption that the `WeakRef` would be kept alive but it seems to not always be true on Windows. This commit makes sure it's kept alive. Signed-off-by: Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63244 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> * test: relax test-memory-usage arrayBuffers check Signed-off-by: inoway46 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63244 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> * tools: update gyp-next to 0.22.2 PR-URL: https://github.com/nodejs/node/pull/63374 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> * tools: bump the eslint group in /tools/eslint with 4 updates Bumps the eslint group in /tools/eslint with 4 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser), [@babel/plugin-syntax-import-source](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-syntax-import-source) and [eslint](https://github.com/eslint/eslint). Updates `@babel/core` from 8.0.0-rc.3 to 8.0.0-rc.4 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.0-rc.4/packages/babel-core) Updates `@babel/eslint-parser` from 8.0.0-rc.3 to 8.0.0-rc.4 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.0-rc.4/eslint/babel-eslint-parser) Updates `@babel/plugin-syntax-import-source` from 8.0.0-rc.3 to 8.0.0-rc.4 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v8.0.0-rc.4/packages/babel-plugin-syntax-import-source) Updates `eslint` from 10.2.0 to 10.2.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/compare/v10.2.0...v10.2.1) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 8.0.0-rc.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@babel/eslint-parser" dependency-version: 8.0.0-rc.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@babel/plugin-syntax-import-source" dependency-version: 8.0.0-rc.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: eslint dependency-version: 10.2.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint ... PR-URL: https://github.com/nodejs/node/pull/63075 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * crypto: align verifyOneShot accepted types Signed-off-by: anshikakalpana <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63280 Fixes: https://github.com/nodejs/node/issues/62903 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * test: deflake watch mode worker test Trigger watch restarts by appending whitespace instead of rewriting watched modules. This avoids transient empty or partial ESM dependency contents while the restarted worker is loading. Use a separate temporary directory for each subtest so concurrent subtests do not share worker and dependency file names. Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5 PR-URL: https://github.com/nodejs/node/pull/63384 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * test: avoid repeated writes in watch helper Use performFileOperation() for test runner watch updates so the run() API path schedules a single delayed write instead of rewriting the file until the second run completes. Repeated writes can trigger another watch restart while the previous rerun is still active. The runner then terminates the in-flight child process with SIGTERM, which can make the captured output include both a failed file-level subtest and the next successful run. Also count only root summary duration lines when detecting completed runs. Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5 PR-URL: https://github.com/nodejs/node/pull/63386 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * doc: update http2's `push` and `trailers` events with `rawHeaders` param Signed-off-by: Yu-Sheng Chen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63259 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * doc: remove the bi-monthly contributor spotlight section PR-URL: https://github.com/nodejs/node/pull/62734 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> * doc: fix article usage before vowel-sound acronyms Several prose references to HTTP, HTTPS, SSL, HPE_HEADER_OVERFLOW and ECMAScript used the article "a" where the acronym starts with a vowel sound and should take "an". The rule is based on pronunciation, not spelling: HTTP is read "aitch-tee-tee-pee", SSL is read "ess-es-el", ECMAScript is read "ek-mah-script", and HPE is read "aitch-pee-ee" — all starting with a vowel sound. Affected files: * doc/api/crypto.md — "disable a SSL 3.0/TLS 1.0 vulnerability" * doc/api/http.md — five occurrences ("a HTTP '400 Bad Request'", "a HTTP '431 Request Header Fields Too Large'", "a HTTP/1.1 102 Processing message", two copies of "use a HTTP parser") plus two references to "a HPE_HEADER_OVERFLOW" * doc/api/http2.md — two code-sample comments reading "// Detects if it is a HTTPS request or HTTP/2" * doc/api/module.md — "compiles a CommonJS, a ECMAScript Module, or a TypeScript module" (only the middle article changes; the adjacent "a CommonJS" and "a TypeScript" are both correct) * doc/api/tls.md — two references to "part of a SSL/TLS handshake" in tlsSocket.getFinished() and tlsSocket.getPeerFinished() No behavior changes, documentation only. Signed-off-by: João Victor Oliveira <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62696 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Jacob Smith <[email protected]> * test: deflake connection refused proxy tests Use 127.0.0.1:10, matching existing refused-connection tests, instead of binding and releasing an ephemeral port that can be reused before the child process connects. Clear NO_PROXY and no_proxy so local proxy bypass settings do not skip the proxy connection attempt. Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5 PR-URL: https://github.com/nodejs/node/pull/63395 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-15.md#jstest-failure Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * test: disable Maglev in near-heap-limit worker test The test expects the worker to run out of memory during startup while creating the message port. With Maglev enabled, the tiny worker heap can be exhausted earlier while generating deoptimization data, which changes the failure mode. Disable Maglev so the induced OOM reaches the path covered by the test. Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5 PR-URL: https://github.com/nodejs/node/pull/63398 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-18.md#jstest-failure Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> * meta: move one or more collaborators to emeritus PR-URL: https://github.com/nodejs/node/pull/63402 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> * doc: remove unsupported template type from v8.md Signed-off-by: Renegade334 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63410 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> * Revert "stream: noop pause/resume on destroyed streams" This reverts commit 29b196694c78fa5f2fd7a9cd5083278deb69241d. Signed-off-by: Stewart X Addison <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63834 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> * test_runner: preserve run duration when using test-rerun Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Aviv Keller <[email protected]> * test_runner: show replayed-from-attempt hint in spec reporter Signed-off-by: Moshe Atlow <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Aviv Keller <[email protected]> * src: expose `node::RegisterContext` to make a node managed context Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62322 Reviewed-By: Joyee Cheung <[email protected]> * test: wait for ok before initial break after restart Signed-off-by: inoway46 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62807 Refs: https://github.com/nodejs/node/issues/61762 Reviewed-By: Luigi Pinca <[email protected]> * doc: fix typo in deprecations Signed-off-by: Daijiro Wachi <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63434 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> * meta: add additional gitignore entries Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63267 Reviewed-By: Matteo Collina <[email protected]> * quic: fixup linting issue after other changes Signed-off-by: James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/63267 Reviewed-By: Matteo Collina <[email protected]> * quic: implement rate limiting for version nego and immediate close Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/63267 Reviewed-By: Matteo Collina <[email protected]> * quic: add reusePort option to QuicEndpoint Signed-off-by: James M Snell <[email protected]> Assisted-by: Opencode:Opus 4.6 PR-URL: https://github.com/nodejs/node/pull/63267 Reviewed-By: Matteo Collina <[email protected]> * stream: fix Writable.toWeb() hang on synchronous drain A race condition in the Writable.toWeb() adapter caused the stream to hang if the underlying Node.js Writable emit…

tools: enable all es6 rules in linter

5e6c3e7

This change enables the es6 environment in eslint. Rather than selecting es6 rules one at a time, this turns all of them on with the exception of modules. Ref: nodejs#5028

Trott added the tools Issues and PRs related to the tools directory. label Feb 3, 2016

Trott mentioned this pull request Feb 3, 2016

.eslintrc: enable es6's spread #5028

Closed

Trott added the lts-watch-v4.x label Feb 3, 2016

Trott closed this Feb 8, 2016

cjihrig mentioned this pull request Feb 13, 2016

tools: update ESLint to version 2.1.0 #5214

Closed

MylesBorins removed the lts-watch-v4.x label Feb 18, 2016

Trott deleted the enable-es6 branch January 13, 2022 22:42

Uh oh!

Uh oh!

Conversation

Trott commented Feb 3, 2016

Uh oh!

cjihrig commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

jbergstroem commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

jbergstroem commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

rvagg commented Feb 3, 2016

Uh oh!

cjihrig commented Feb 3, 2016

Uh oh!

jasnell commented Feb 3, 2016

Uh oh!

cjihrig commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

thefourtheye commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

Trott commented Feb 3, 2016

Uh oh!

rvagg commented Feb 4, 2016

Uh oh!

cjihrig commented Feb 4, 2016

Uh oh!

thefourtheye commented Feb 4, 2016

Uh oh!

Trott commented Feb 4, 2016

Uh oh!

Fishrock123 commented Feb 4, 2016

Uh oh!

Trott commented Feb 5, 2016

Uh oh!

rvagg commented Feb 8, 2016

Uh oh!

mhdawson commented Feb 8, 2016

Uh oh!

jasnell commented Feb 8, 2016

Uh oh!

Trott commented Feb 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants