Conversation
Member
There was a problem hiding this comment.
It might be better with test-async-wrap-check-providers to handle it in the test itself, otherwise you might be missing out on some real regressions (it's a test that tests a number of subsystems, fs.watch() is just one of them.)
If you do, you should note it in the comment here so it's not forgotten about.
Member
|
Left a suggestion but LGTM if you don't want to take it. |
Member
Author
|
Good point, I'll take a look at test-async-wrap-check-providers to look at just excluding the required part. |
fs watch currently needs special configuration on AIX and we want to improve under nodejs#5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX
Member
Author
|
@bnoordhuis updated |
Member
|
LGTM |
Member
Author
mhdawson
added a commit
that referenced
this pull request
Feb 16, 2016
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Member
Author
|
landed as 6a85ad9 |
Member
Author
|
CI run to confirm on AIX: https://ci.nodejs.org/job/node-test-commit-aix/46/ |
Member
Author
|
confirmed we are down to the 1 unrelated failure in the AIX runs, closing |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 18, 2016
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
fs watch currently needs special configuration on AIX and we want to improve under nodejs#5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: nodejs#5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
fs watch currently needs special configuration on AIX and we want to improve under #5085. Tests are disabled so CI can be green and we can spot other regressions until this work is complete. test-async-wrap-check-providers does not aim to test fs watch but part of the test uses it so that part has been skipped for AIX PR-URL: #5187 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs watch currently needs special configuration on AIX and we
want to improve under #5085.
Tests are disabled so CI can be green and we can spot other
regressions until this work is complete.
test-async-wrap-check-providers does not aim to test fs watch
but uses it as part of what it is testing so its included in
those disabled.