Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: deflake test-http2-client-socket-destroy #58212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

test: deflake test-http2-client-socket-destroy #58212

merged 1 commit into from
May 9, 2025

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 7, 2025

The socket can be destroyed by the other peer while data is still being written. Add a listener for the 'error' event.

@lpinca
test: deflake test-http2-client-socket-destroy
3ae3ea7 
The socket can be destroyed by the other peer while data is still being
written. Add a listener for the `'error'` event.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 7, 2025
@lpinca
Copy link
Member Author

lpinca commented May 7, 2025

This should fix https://ci.nodejs.org/job/node-test-commit-osx/64927/nodes=osx13-x64/testReport/junit/(root)/parallel/test_http2_client_socket_destroy/

---
duration_ms: 202.502
exitcode: 1
severity: fail
stack: |-
  node:events:485
        throw er; // Unhandled 'error' event
        ^

  Error: read ECONNRESET
      at TCP.onStreamRead (node:internal/stream_base_commons:216:20)
  Emitted 'error' event on ServerHttp2Stream instance at:
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    errno: -54,
    code: 'ECONNRESET',
    syscall: 'read'
  }

  Node.js v24.0.0-pre
...

@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (b21574d) to head (3ae3ea7).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58212   +/-   ##
=======================================
  Coverage   90.13%   90.14%           
=======================================
  Files         629      629           
  Lines      186628   186628           
  Branches    36632    36623    -9     
=======================================
+ Hits       168218   168227    +9     
+ Misses      11219    11207   -12     
- Partials     7191     7194    +3

see 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14883893336

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66680/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66691/

@lpinca lpinca removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 8, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 508cd0f into nodejs:main May 9, 2025
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 508cd0f

@lpinca lpinca deleted the deflake/test-http2-client-socket-destroy branch May 9, 2025 19:18
targos pushed a commit that referenced this pull request May 16, 2025
@lpinca @targos
test: deflake test-http2-client-socket-destroy
ebb82aa 
The socket can be destroyed by the other peer while data is still being
written. Add a listener for the `'error'` event.

PR-URL: #58212
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@lpinca @aduh95
test: deflake test-http2-client-socket-destroy
8bafc0f 
The socket can be destroyed by the other peer while data is still being
written. Add a listener for the `'error'` event.

PR-URL: #58212
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @joyeecheung @jakecastelli