Thanks to visit codestin.com
Credit goes to github.com

Skip to content

doc: graduate Symbol.dispose/asyncDispose from experimental #58467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

doc: graduate Symbol.dispose/asyncDispose from experimental #58467

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 26, 2025

Now that Symbol.dispose and Symbol.asyncDispose have been enabled by default and are expected to likely advance to stage 4 this week, let's graduate them from experimental status.

@jasnell
doc: graduate Symbol.dispose/asyncDispose from experimental
cd8078e 
Now that Symbol.dispose and Symbol.asyncDispose have been
enabled by default and are expected to likely advance to
stage 4 this week, let's graduate them from experimental
status.
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label May 26, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 26, 2025
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
jasnell
jasnell commented May 26, 2025
View reviewed changes
@jasnell jasnell added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x labels May 26, 2025
@jasnell
Copy link
Member Author

jasnell commented May 26, 2025

Marking as don't land on anything before 24.x since it wasn't until 24.x that ERM was enabled by default.

@jasnell jasnell requested review from cjihrig, mcollina and aduh95 May 26, 2025 16:00
@legendecas
Copy link
Member

Should we wait for the proposal to be officially promoted to Stage 4 this week?

@jasnell
Copy link
Member Author

jasnell commented May 26, 2025

We can, for sure. There's no rush to land this.

@mcollina
Copy link
Member

Please wait for that.

@legendecas legendecas added the blocked PRs that are blocked by other issues or PRs. label May 26, 2025
@legendecas legendecas removed the blocked PRs that are blocked by other issues or PRs. label May 28, 2025
@legendecas
Copy link
Member

The proposal has confirmed to stage 4.

@jasnell
Copy link
Member Author

jasnell commented May 28, 2025

Landed in ba6651a

@jasnell jasnell closed this May 28, 2025
This was referenced May 29, 2025
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 8, 2025
Merged
@lucacasonato lucacasonato mentioned this pull request Jun 12, 2025
Open
@legendecas legendecas added the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label Jun 12, 2025
@legendecas
Copy link
Member

Adding https://github.com/nodejs/node/labels/dont-land-on-v24.x to wait for conclusion on #58689

@targos targos removed the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label Jun 12, 2025
@targos
Copy link
Member

targos commented Jun 12, 2025

It's too late. This was released in v24.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @legendecas @mcollina @targos @anonrig @cjihrig @dario-piotrowicz