perf_hooks: fix stack overflow error #60084
Open
+59
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60084 +/- ##
==========================================
+ Coverage 88.43% 88.45% +0.01%
==========================================
Files 703 703
Lines 207795 207819 +24
Branches 40022 40029 +7
==========================================
+ Hits 183767 183824 +57
+ Misses 16021 15976 -45
- Partials 8007 8019 +12
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Oct 1, 2025
| */ | ||
| primordials.SafeArrayPrototypePushApply = (arr, items) => { | ||
| let start = 0; | ||
| let end = start + 0x1000; |
There was a problem hiding this comment.
Is there any reason not to make this just end = 4096?
| let end = start + 0x1000; | ||
| while (end < items.length) { | ||
| ArrayPrototypePushApply(arr, ArrayPrototypeSlice(items, start, start = end)); | ||
| end += 0x1000; |
There was a problem hiding this comment.
It seems like the code may be more readable if 4096 was used instead of hex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #54772, as suggested by #54772 (comment)