Codestin Search App

wantaekchoi · 2025-10-27T06:41:52Z

stream: add bytes() method to stream/consumers

Add a bytes() method to the stream/consumers module that returns a Uint8Array, providing a convenient way to consume streams as typed arrays.

Fixes: #59542

nodejs-github-bot · 2025-10-27T06:41:58Z

Review requested:

@nodejs/streams

codecov · 2025-10-27T18:16:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (4fe325d) to head (2cad010).
⚠️ Report is 631 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60426      +/-   ##
==========================================
+ Coverage   88.58%   89.79%   +1.21%     
==========================================
  Files         704      673      -31     
  Lines      207823   203830    -3993     
  Branches    40049    39174     -875     
==========================================
- Hits       184101   183037    -1064     
+ Misses      15772    13140    -2632     
+ Partials     7950     7653     -297

Files with missing lines	Coverage Δ
lib/stream/consumers.js	`100.00% <100.00%> (ø)`

... and 256 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: nodejs#59542

lib/stream/consumers.js

Co-authored-by: René <[email protected]>

Ethan-Arrowood

This LGTM but I'm not explicitly approving it. I don't know why we really need this when user's could do new Uint8Array(await arrayBuffer(stream)); themselves (or rather any conversion from the raw ArrayBuffer).

Ethan-Arrowood · 2025-11-03T17:04:52Z

Looking at the issue, I see this is meant to align us with the new bytes() method from fetch spec: https://developer.mozilla.org/en-US/docs/Web/API/Response/bytes

I'm okay with that then :) nice work!

doc/api/webstreams.md

Co-authored-by: jakecastelli <[email protected]>

gurgunday

lgtm

test/parallel/test-stream-consumers.js

nodejs-github-bot · 2026-01-29T10:21:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71118/

nodejs-github-bot · 2026-01-29T13:24:41Z

Landed in 938f175

- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: #59542 PR-URL: #60426 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Notable changes: async_hooks: * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415 src: * improve textEncoder encode performance with simdutf (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426 test_runner: * (SEMVER-MINOR) add env option to run function (Ethan Arrowood) #61367 url: * update ada to v3.4.2 and support unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635

- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: #59542 PR-URL: #60426 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Notable changes: async_hooks: * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 src: * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548 * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496 stream: * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426 test_runner: * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367 url: * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593 PR-URL: #61635

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Oct 27, 2025

H4ad added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 27, 2025

wantaekchoi force-pushed the add-stream-consumers-bytes branch 2 times, most recently from 3887f53 to 4117fc0 Compare October 27, 2025 21:41

stream: add bytes() method to stream/consumers

b6a5a18

- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: nodejs#59542

wantaekchoi force-pushed the add-stream-consumers-bytes branch from 4117fc0 to b6a5a18 Compare October 27, 2025 21:53

Renegade334 reviewed Oct 30, 2025

View reviewed changes

lib/stream/consumers.js Outdated Show resolved Hide resolved

Use arrayBuffer() for direct Uint8Array conversion.

79491e0

Co-authored-by: René <[email protected]>

wantaekchoi requested a review from Renegade334 November 3, 2025 05:57

Ethan-Arrowood reviewed Nov 3, 2025

View reviewed changes

Ethan-Arrowood approved these changes Nov 3, 2025

View reviewed changes

Renegade334 reviewed Nov 3, 2025

View reviewed changes

doc/api/webstreams.md Show resolved Hide resolved

docs: add explicit Buffer import in bytes() examples

2316bec

wantaekchoi requested a review from Renegade334 November 3, 2025 22:40

jakecastelli reviewed Nov 28, 2025

View reviewed changes

doc/api/webstreams.md Outdated Show resolved Hide resolved

Fix added version value

a2b7fe6

Co-authored-by: jakecastelli <[email protected]>

Renegade334 approved these changes Nov 29, 2025

View reviewed changes

Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 29, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2025

This comment was marked as outdated.

Sign in to view

jakecastelli approved these changes Nov 30, 2025

View reviewed changes

jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2025

MattiasBuelens approved these changes Nov 30, 2025

View reviewed changes

avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2025

This comment was marked as outdated.

Sign in to view

benjamingr approved these changes Dec 20, 2025

View reviewed changes

gurgunday approved these changes Dec 20, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Renegade334 reviewed Jan 28, 2026

View reviewed changes

test/parallel/test-stream-consumers.js Outdated Show resolved Hide resolved

test: satisfy eslint

2cad010

Renegade334 requested review from Ethan-Arrowood, gurgunday and jakecastelli January 28, 2026 16:47

jakecastelli approved these changes Jan 29, 2026

View reviewed changes

Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026

This comment has been minimized.

Sign in to view

Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026

nodejs-github-bot merged commit 938f175 into nodejs:main Jan 29, 2026
66 of 67 checks passed

github-actions bot mentioned this pull request Feb 2, 2026

2026-02-03, Version 25.6.0 (Current) #61635

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stream: add bytes() method to stream/consumers#60426

stream: add bytes() method to stream/consumers#60426
nodejs-github-bot merged 5 commits intonodejs:mainfrom
wantaekchoi:add-stream-consumers-bytes

wantaekchoi commented Oct 27, 2025

Uh oh!

nodejs-github-bot commented Oct 27, 2025

Uh oh!

codecov bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Ethan-Arrowood left a comment

Uh oh!

Ethan-Arrowood commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

gurgunday left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Jan 29, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

wantaekchoi commented Oct 27, 2025

stream: add bytes() method to stream/consumers

Uh oh!

nodejs-github-bot commented Oct 27, 2025

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

Ethan-Arrowood commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Jan 29, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov bot commented Oct 27, 2025 •

edited

Loading