Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sqlite: enable Percentile extension#61295

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
TheOneTheOnlyJJ:sqlite-enable-percentile
Jan 18, 2026
Merged

sqlite: enable Percentile extension#61295
nodejs-github-bot merged 1 commit intonodejs:mainfrom
TheOneTheOnlyJJ:sqlite-enable-percentile

Conversation

@TheOneTheOnlyJJ
Copy link
Contributor

@TheOneTheOnlyJJ TheOneTheOnlyJJ commented Jan 6, 2026

Refs: #60618

This enables the SQLite Percentile extension added to the amalgamation with the release of SQLite v3.51.0 (#60614) by adding the SQLITE_ENABLE_PERCENTILE flag to both the GYP and GN SQLite builds.

The changes were made by following the pattern set by #57621.

This also addresses a minor review comment left unhandled in #57621 (comment).

A new test was added to test/parallel/test-sqlite.js to verify that the percentile() function is available at runtime. The test is placed immediately after the existing math functions test for two reasons:

  1. SQLITE_ENABLE_PERCENTILE follows SQLITE_ENABLE_MATH_FUNCTIONS alphabetically in the build configuration.
  2. percentile() is logically related to the mathematical function set.

This change does not enable the mentioned Carray extension from #60618 and does not include the SQLITE_ENABLE_ORDERED_SET_AGGREGATES flag for enabling the WITHIN GROUP syntax. Those are left for separate discussion and follow-up.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 6, 2026

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (bcdf2e0) to head (86b8170).
⚠️ Report is 95 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61295      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         704      704              
  Lines      208759   208739      -20     
  Branches    40281    40278       -3     
==========================================
- Hits       184816   184775      -41     
- Misses      15947    15981      +34     
+ Partials     7996     7983      -13

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheOneTheOnlyJJ TheOneTheOnlyJJ changed the title sqlite: Enable SQLite Percentile extension sqlite: enable SQLite Percentile extension Jan 8, 2026
@TheOneTheOnlyJJ TheOneTheOnlyJJ changed the title sqlite: enable SQLite Percentile extension sqlite: enable Percentile extension Jan 8, 2026
@TheOneTheOnlyJJ TheOneTheOnlyJJ force-pushed the sqlite-enable-percentile branch from 2ba1db0 to 86b8170 Compare January 9, 2026 09:38
@TheOneTheOnlyJJ
Copy link
Contributor Author

TheOneTheOnlyJJ commented Jan 9, 2026

@geeksilva97

Since you worked on #57621 and this PR follows the same pattern, could you take a look at this?
It’s my first contribution to Node, and I based this directly on the work you did there.
The initial CI failure was due to improper commit message capitalization, which I fixed with a force-push.
I ran a local build and the relevant tests, and they pass.

@TheOneTheOnlyJJ
Copy link
Contributor Author

TheOneTheOnlyJJ commented Jan 15, 2026

@cjihrig

Since this is not getting any activity lately, could you take a look at it so things get moving again?

cjihrig
cjihrig approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70822/

@geeksilva97
Copy link
Contributor

geeksilva97 commented Jan 16, 2026

@geeksilva97

Since you worked on #57621 and this PR follows the same pattern, could you take a look at this? It’s my first contribution to Node, and I based this directly on the work you did there. The initial CI failure was due to improper commit message capitalization, which I fixed with a force-push. I ran a local build and the relevant tests, and they pass.

Sorry for the delay. LGTM

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70830/

@TheOneTheOnlyJJ
Copy link
Contributor Author

TheOneTheOnlyJJ commented Jan 17, 2026

It looks like the remaining CI failures are unrelated to this PR.

Could someone with permissions retrigger CI, or should we wait for upstream fixes to the failing tests?

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2026
@geeksilva97
Copy link
Contributor

geeksilva97 commented Jan 17, 2026

It looks like the remaining CI failures are unrelated to this PR.

Could someone with permissions retrigger CI, or should we wait for upstream fixes to the failing tests?

done

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70857/

@TheOneTheOnlyJJ
Copy link
Contributor Author

TheOneTheOnlyJJ commented Jan 18, 2026

Does this need the needs-ci anymore?

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2026
@nodejs-github-bot nodejs-github-bot merged commit 637bda0 into nodejs:main Jan 18, 2026
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2026

Landed in 637bda0

@louwers
Copy link
Contributor

louwers commented Jan 19, 2026

@TheOneTheOnlyJJ It's a bit confusing, but needs-ci means that a PR needs a CI run to land. It does not mean that it still needs CI.

@aduh95 aduh95 added the backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. label Jan 20, 2026
@aduh95
Copy link
Contributor

aduh95 commented Jan 20, 2026

Test failure on v25.x-staging with this change:

=== release test-sqlite ===                   
Path: parallel/test-sqlite
Test failure: 'percentile is enabled'
Location: test/parallel/test-sqlite.js:207:3
Error: no such function: percentile
    at TestContext.<anonymous> (…/test/parallel/test-sqlite.js:215:10)
    at Test.runInAsyncScope (node:async_hooks:212:14)
    at Test.run (node:internal/test_runner/test:1109:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:786:18)
    at Test.postRun (node:internal/test_runner/test:1238:19)
    at Test.run (node:internal/test_runner/test:1166:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
    at async Promise.all (index 0)
    at async Suite.run (node:internal/test_runner/test:1524:7)
    at async Test.processPendingSubtests (node:internal/test_runner/test:786:7) {
  code: 'ERR_SQLITE_ERROR',
  errcode: 1,
  errstr: 'SQL logic error'
}

We'll need a manual backport PR if we want the change backported

islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
@TheOneTheOnlyJJ @islandryu
sqlite: enable Percentile extension
7bbce2f 
PR-URL: nodejs#61295
Refs: nodejs#60618
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@TheOneTheOnlyJJ
Copy link
Contributor Author

TheOneTheOnlyJJ commented Jan 25, 2026 •
edited
Loading

@aduh95 @islandryu Thanks for flagging!

This is very likely due to #60614 not being on v25.x.
That needs to be backported first for this to work.

@aduh95 aduh95 mentioned this pull request Jan 25, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+1 more reviewer

@louwers louwers louwers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@TheOneTheOnlyJJ @nodejs-github-bot @geeksilva97 @louwers @aduh95 @cjihrig @RafaelGSS @avivkeller