src: throw RangeError on failed ArrayBuffer BackingStore allocation#61480
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 25, 2026
Merged
src: throw RangeError on failed ArrayBuffer BackingStore allocation#61480nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError, aligning with V8's OutOfMemory error type.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61480 +/- ##
==========================================
+ Coverage 89.85% 89.86% +0.01%
==========================================
Files 665 665
Lines 203290 203309 +19
Branches 39081 39088 +7
==========================================
+ Hits 182667 182710 +43
+ Misses 12977 12945 -32
- Partials 7646 7654 +8
🚀 New features to boost your workflow:
|
Collaborator
cjihrig
approved these changes
Jan 23, 2026
Collaborator
Collaborator
|
Landed in 3fed9fb |
aduh95
pushed a commit
that referenced
this pull request
Jan 28, 2026
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError, aligning with V8's OutOfMemory error type. PR-URL: #61480 Refs: https://github.com/nodejs/node/blob/c755b0113ce0cb6d83baf2cf070ba381a5673db2/deps/v8/src/builtins/builtins-typed-array.cc#L584 Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates
ERR_MEMORY_ALLOCATION_FAILEDto be a RangeError,aligning with V8's OutOfMemory error type and ECMAScript's OutOfMemory
error type.
There are still many call sites in crypto, tls and quic need to be reviewed
to properly handle the failed ArrayBuffer BackingStore allocation. This
PR updates call sites not in these modules.
Refs:
node/deps/v8/src/builtins/builtins-typed-array.cc
Line 584 in c755b01
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Refs: #61403 (comment)