test: split test-fs-watch-ignore-*#61494
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jan 30, 2026
Merged
Conversation
Split and simplify the tests into individual files. Refs: nodejs#61433
lpinca
commented
Jan 23, 2026
| skipIfNoWatch(); | ||
|
|
||
| // if (common.isSunOS) | ||
| // common.skip('`fs.watch()` is not reliable on SunOS.'); |
Member
Author
There was a problem hiding this comment.
These should be replaced with entries in test/parallel/parallel.status but I can't find a tracking issue.
Comment on lines
27
to
28
| // Do the write with a delay to ensure that the OS is ready to notify us. See | ||
| // https://github.com/nodejs/node/issues/52601. |
Member
Author
There was a problem hiding this comment.
I don't know if the delay is needed only on macOS. If so, it would be better to conditionally delay writing using common.isMacOS to avoid wasting time on other platforms.
Member
There was a problem hiding this comment.
I think on macOS at least, this is needed, otherwise it's known to cause flakes due to FSEvents coalescing. Not sure about other platforms.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61494 +/- ##
==========================================
- Coverage 89.82% 89.78% -0.05%
==========================================
Files 667 672 +5
Lines 203693 203930 +237
Branches 39163 39204 +41
==========================================
+ Hits 182963 183090 +127
- Misses 13061 13171 +110
Partials 7669 7669 🚀 New features to boost your workflow:
|
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
@joyeecheung PTAL |
joyeecheung
approved these changes
Jan 26, 2026
Collaborator
|
Landed in e67848a |
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
Split and simplify the tests into individual files. Refs: #61433 PR-URL: #61494 Reviewed-By: Joyee Cheung <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
Split and simplify the tests into individual files. Refs: #61433 PR-URL: #61494 Reviewed-By: Joyee Cheung <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 3, 2026
Split and simplify the tests into individual files. Refs: #61433 PR-URL: #61494 Reviewed-By: Joyee Cheung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split and simplify the tests into individual files.
Refs: #61433