Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sqlite: reserve local vectors space#61540

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
araujogui:sqlite/reserve-vectors
Jan 29, 2026
Merged

sqlite: reserve local vectors space#61540
nodejs-github-bot merged 2 commits intonodejs:mainfrom
araujogui:sqlite/reserve-vectors

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Jan 27, 2026

Reserve local vectors to prevent reallocations

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 27, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (8fd5f6b) to head (ec4defd).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61540      +/-   ##
==========================================
- Coverage   89.79%   89.78%   -0.01%     
==========================================
  Files         672      672              
  Lines      203756   203756              
  Branches    39169    39166       -3     
==========================================
- Hits       182956   182937      -19     
- Misses      13135    13159      +24     
+ Partials     7665     7660       -5
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.66% <100.00%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334
Renegade334 approved these changes Jan 27, 2026
View reviewed changes
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 27, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71072/

@araujogui araujogui force-pushed the sqlite/reserve-vectors branch from af35d93 to ec4defd Compare January 27, 2026 20:32
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71109/

@Renegade334 Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026
@nodejs-github-bot nodejs-github-bot merged commit 68d7b6f into nodejs:main Jan 29, 2026
74 of 75 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 29, 2026

Landed in 68d7b6f

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@araujogui @aduh95
sqlite: reserve vectors space
d1796c5 
PR-URL: #61540
Reviewed-By: René <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@araujogui @aduh95
sqlite: reserve vectors space
6993386 
PR-URL: #61540
Reviewed-By: René <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@araujogui @nodejs-github-bot @cjihrig @Renegade334 @geeksilva97 @RafaelGSS @addaleax