test_runner: print coverage and diagnostics with dot reporter - #61891
Closed
madkate42 wants to merge 2 commits into
Closed
test_runner: print coverage and diagnostics with dot reporter#61891madkate42 wants to merge 2 commits into
madkate42 wants to merge 2 commits into
Conversation
diagnostics with dot reporter
Collaborator
|
Review requested:
|
pmarchini
reviewed
Feb 19, 2026
| fixture, | ||
| ]); | ||
|
|
||
| const stdout = result.stdout.toString(); |
Member
There was a problem hiding this comment.
Could you please add a snapshot test too?
Author
There was a problem hiding this comment.
great catch, thank you, added in this commit.
let me know if this could be improved!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61891 +/- ##
==========================================
- Coverage 91.70% 89.77% -1.93%
==========================================
Files 337 674 +337
Lines 140026 204906 +64880
Branches 21745 39385 +17640
==========================================
+ Hits 128410 183964 +55554
- Misses 11393 13233 +1840
- Partials 223 7709 +7486
🚀 New features to boost your workflow:
|
pmarchini
approved these changes
Mar 2, 2026
pmarchini
requested changes
Mar 2, 2026
pmarchini
left a comment
Member
There was a problem hiding this comment.
The tests are failing and the failures seem to be related!
Contributor
|
The failures appear to be due to outdated snapshots. Running: |
Member
|
Duplicate of #61423 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the dot reporter with coverage thresholds, coverage failure messages and the coverage report were not displayed. The dot reporter only handled
test:passandtest:failevents, ignoringtest:diagnosticandtest:coverageevents.This change adds handlers for these events, displaying:
after the test dots complete.
Fixes: #60884
Refs: #52655
Test plan
test/parallel/test-runner-coverage-thresholds.jsfor dot reporter coverage failures