src: use simdutf for two-byte string utf8 conversion in utf8 value - #62248
Merged
nodejs-github-bot merged 1 commit intoAug 21, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
mertcanaltin
force-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
from
March 14, 2026 08:31
f6d6f82 to
d459594
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62248 +/- ##
==========================================
- Coverage 90.33% 90.32% -0.02%
==========================================
Files 760 760
Lines 248523 248530 +7
Branches 46906 46892 -14
==========================================
- Hits 224511 224481 -30
- Misses 15451 15464 +13
- Partials 8561 8585 +24
🚀 New features to boost your workflow:
|
lemire
reviewed
Mar 14, 2026
mertcanaltin
force-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
5 times, most recently
from
March 14, 2026 17:12
dcbf493 to
fb16b2d
Compare
lemire
reviewed
Mar 22, 2026
lemire
approved these changes
Mar 22, 2026
lemire
left a comment
Member
There was a problem hiding this comment.
this look fine, see my comment.
gurgunday
approved these changes
Mar 22, 2026
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
mertcanaltin
force-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
from
August 10, 2026 00:13
19f636f to
1a357a0
Compare
Signed-off-by: Mert Can Altin <[email protected]>
mertcanaltin
force-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
from
August 10, 2026 00:18
1a357a0 to
0cb2a0b
Compare
anonrig
approved these changes
Aug 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Contributor
|
request-ci
I started a new Jenkins job https://ci.nodejs.org/job/node-test-pull-request/76039/ manually in Jenkins and that is now running. |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
|
Landed in 610fcd8 |
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Mert Can Altin <[email protected]> PR-URL: #62248 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Mert Can Altin <[email protected]> PR-URL: #62248 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latin-1 already used simdutf #61696,
I changed WriteUtf8V2 to simdutf for two-byte strings.
➜ node git:(mert/use-simdutf-for-two-byte-utf8) ✗ node-benchmark-compare ./result.csv confidence improvement accuracy (*) (**) (***) util/utf8-value.js n=5000000 type='ascii' -0.11 % ±2.64% ±3.69% ±5.18% util/utf8-value.js n=5000000 type='mixed' *** 49.60 % ±1.90% ±2.67% ±3.78% util/utf8-value.js n=5000000 type='three_bytes' *** 31.10 % ±2.42% ±3.34% ±4.60% util/utf8-value.js n=5000000 type='two_bytes' *** 42.75 % ±1.42% ±1.94% ±2.66% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case, there are 4 comparisons, you can thus expect the following amount of false-positive results: 0.20 false positives, when considering a 5% risk acceptance (*, **, ***), 0.04 false positives, when considering a 1% risk acceptance (**, ***), 0.00 false positives, when considering a 0.1% risk acceptance (***)