fs: fix glob case-sensitivity inconsistencies - #63446
Closed
louiellan wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
For additional info with a directory structure: sample.js const fs = require('node:fs')
// test-1
let files = fs.globSync('a/index.TXT', { exclude: ['a/index.txt'] })
console.log(files)
// test-2
files = fs.globSync('a/index.TXT', { exclude: ['a/in*dex.txt'] })
console.log(files)
// test-3
files = fs.globSync('a/index.TXT', { exclude: ['a*/index.txt'] })
console.log(files)In with only a literal string, like those in the |
where the `exclude` option is case sensitive but the `pattern` is a case insensitive operation (on Windows and MacOS), thus results to any casing difference in matched list not to be filtered out and does not return the true casing of a matched directory / file Signed-off-by: louiellan <[email protected]>
louiellan
force-pushed
the
fix-exclude-glob
branch
from
May 20, 2026 22:10
75c8645 to
a1aa147
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63446 +/- ##
==========================================
+ Coverage 90.05% 90.08% +0.03%
==========================================
Files 714 714
Lines 225876 225918 +42
Branches 42737 42745 +8
==========================================
+ Hits 203408 203514 +106
+ Misses 14244 14185 -59
+ Partials 8224 8219 -5
🚀 New features to boost your workflow:
|
Contributor
Author
|
Fixing this bug alone could introduce confusion on glob's case sensitivity, especially in resolving canonical paths, I'm closing this PR in favor of the feature request #58991 (comment) |
yhay81
added a commit
to yhay81/node
that referenced
this pull request
Aug 31, 2026
On case-insensitive platforms include patterns match entries regardless of case, but literal (non-magic) exclude patterns were matched case-sensitively because exclude matchers are created with nocaseMagicOnly. Exclusion is a pure string match with no filesystem lookups, so disable nocaseMagicOnly for exclude matchers. Fixes: nodejs#58991 Refs: nodejs#63446 Signed-off-by: Yusuke Hayashi <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
On case-insensitive platforms include patterns match entries regardless of case, but literal (non-magic) exclude patterns were matched case-sensitively because exclude matchers are created with nocaseMagicOnly. Exclusion is a pure string match with no filesystem lookups, so disable nocaseMagicOnly for exclude matchers. Fixes: #58991 Refs: #63446 Signed-off-by: Yusuke Hayashi <[email protected]> PR-URL: #64817 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 3, 2026
On case-insensitive platforms include patterns match entries regardless of case, but literal (non-magic) exclude patterns were matched case-sensitively because exclude matchers are created with nocaseMagicOnly. Exclusion is a pure string match with no filesystem lookups, so disable nocaseMagicOnly for exclude matchers. Fixes: #58991 Refs: #63446 Signed-off-by: Yusuke Hayashi <[email protected]> PR-URL: #64817 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #58991
fix matchers'
nocaseMagicOnlyoption where it makes any non-magical/literal pattern case-sensitive which results to:making the
excludeoption case sensitivenot returning the actual casing of a matched directory / file
not ideal for the case-insensitive nature of Windows and MacOS filesystems.
It would be a
notable-changesince developers may have been relying already on this behavior