Thanks to visit codestin.com
Credit goes to github.com

Skip to content

src: fix comment typos - #64509

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sjungwon03:src/fix-comment-typos-rerun
Jul 17, 2026
Merged

src: fix comment typos#64509
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sjungwon03:src/fix-comment-typos-rerun

Conversation

@sjungwon03

@sjungwon03 sjungwon03 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fix typos in source comments.

- // Eagerly compile primordials/boostrap/main scripts during code cache
+ // Eagerly compile primordials/bootstrap/main scripts during code cache

- // If any bulitins should be eagerly compiled i.e. with inner functions
+ // If any builtins should be eagerly compiled i.e. with inner functions

- // documentation suggets. As a compromise, we currently only block on
+ // documentation suggests. As a compromise, we currently only block on

- // that criticl user-blocking tasks are not lost.
+ // that critical user-blocking tasks are not lost.

- // If the stream is not a local undirectional stream and is_readable is
+ // If the stream is not a local unidirectional stream and is_readable is

This supersedes #64488, which was closed after an unrelated macOS
test-debugger-exec timeout. This PR is based on the current main branch.

@sjungwon03
src: fix comment typos
f9179cd 
Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (7a11a9b) to head (f9179cd).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #64509   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         739      739           
  Lines      241669   241669           
  Branches    45543    45552    +9     
=======================================
+ Hits       218087   218098   +11     
+ Misses      15150    15110   -40     
- Partials     8432     8461   +29
Files with missing lines Coverage Δ
src/node_builtins.cc 76.13% <ø> (-0.38%) ⬇️
src/node_builtins.h 100.00% <ø> (ø)
src/node_platform.cc 76.24% <ø> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry

pimterry commented Jul 15, 2026

Copy link
Copy Markdown
Member

Thanks @sjungwon03.

In future though, there's no need to open a new PR if a CI job fails. Just check the cause: if it seems like it's a flaky test issue unrelated to the change then somebody can re-run it to get it passing. Alternatively if it's an actual issue in the change you can push another commit to fix the problem.

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 15, 2026
@sjungwon03

sjungwon03 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification. I’ll check the failure first next time and keep the existing PR open if it is unrelated to the change. I’ll push a follow-up commit only when the failure is caused by my change.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74828/

@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74835/

@pimterry pimterry added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 17, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 358adc8 into nodejs:main Jul 17, 2026
84 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Landed in 358adc8

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@sjungwon03 @aduh95
src: fix comment typos
4102ad5 
Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <[email protected]>
PR-URL: #64509
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@sjungwon03 @aduh95
src: fix comment typos
d2956fe 
Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <[email protected]>
PR-URL: #64509
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
@sjungwon03 @RafaelGSS
src: fix comment typos
6ff5a1b 
Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <[email protected]>
PR-URL: #64509
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@sjungwon03 @aduh95
src: fix comment typos
3650fab 
Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <[email protected]>
PR-URL: #64509
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@pimterry pimterry pimterry approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjungwon03 @nodejs-github-bot @pimterry @lpinca