Conversation
Collaborator
|
Review requested:
|
avivkeller
approved these changes
Jul 25, 2026
avivkeller
left a comment
Member
There was a problem hiding this comment.
While intentionally adding a thing we don't recommend is odd to me, LGTM to unbreak consumers
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
Thanks for the update, I'll wait until the security release is out and then revisit this PR. Appreciate you taking a look. |
Contributor
|
nodejs/citgm#1112 shows Yarn 4.18.0 failing in CITGM tests (without this PR). It's possible that there are multiple issues contributing to failure. |
marco-ippolito
force-pushed
the
v22.x-staging
branch
from
July 29, 2026 13:35
a6b3a35 to
400e833
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ash2228
force-pushed
the
v22.x-backport-62835
branch
from
July 29, 2026 14:16
40e2961 to
7dd23a7
Compare
Author
|
Thanks, I rebased the PR onto the latest v22.x-staging (currently based on 400e833). Let me know if there's anything else I should update. |
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
approved these changes
Jul 29, 2026
juanarbol
force-pushed
the
v22.x-staging
branch
2 times, most recently
from
August 21, 2026 17:53
6543035 to
7c2df5d
Compare
juanarbol
force-pushed
the
v22.x-backport-62835
branch
from
August 31, 2026 14:09
7dd23a7 to
6cc7898
Compare
Temporarily restore fs patchability in ESM loader as a workaround for helping downstream projects that depend on this undocumented hidden contract transition into using hook proper APIs. This patch intentionally avoids adding a test and instead adds warning comments to hopefully steer new code away from depending on it. PR-URL: nodejs#62835 Backport-PR-URL: nodejs#64722 Refs: nodejs#62012 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Signed-off-by: Ash <[email protected]>
juanarbol
force-pushed
the
v22.x-backport-62835
branch
from
August 31, 2026 14:21
6cc7898 to
db125c6
Compare
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - fs: restore fs patchability in ESM loader ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/34174856736 |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
juanarbol
pushed a commit
that referenced
this pull request
Sep 14, 2026
Temporarily restore fs patchability in ESM loader as a workaround for helping downstream projects that depend on this undocumented hidden contract transition into using hook proper APIs. This patch intentionally avoids adding a test and instead adds warning comments to hopefully steer new code away from depending on it. PR-URL: #62835 Backport-PR-URL: #64722 Refs: #62012 Signed-off-by: Ash <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Mike McCready <[email protected]>
Member
|
Landed in 37f2106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62835 to the v22.x line.
#62835 landed on
mainin 9531947 and was backported to v26.x (v26.1.0)and v24.x (v24.16.0), but not to v22.x. It did not cherry-pick cleanly onto
v22 —
lib/internal/modules/esm/load.jsconflicted, which is likely why itwas missed.
This fixes #64709. Under Yarn PnP on v22.22.3 through v22.23.1, the ESM
loader captures
readFileSync/realpathSyncbefore PnP patchesfs, soNode cannot read sources from the zip cache itself. PnP supplies the source
through its load hook instead, which routes loading through the synthetic
require in
loadCJSModule— that one does not setcacheorextensions.Result:
rechoir/webpack-cliandimport-fresh/postcss-loaderbothbreak.
Conflict resolution: v22's
load.jsalso importsgetOptionValuefor--experimental-default-type, which does not exist on the newer lines. Thatimport is preserved; only the
fsimport and call sites changed. The restThe rest applied cleanly from 9531947.
The v22 build is still compiling locally, so I haven't yet run the
reproducer against a patched binary — I'll follow up with before/after
output. Opening now so it's visible in case someone wants to pick it up
sooner.