Codestin Search App

anonrig · 2026-08-18T01:12:18Z

Speeds up new URL() / URL.parse() on the common path: already-serialized ASCII hrefs.

The binding currently always:

Copies the V8 string into a UTF-8 buffer (Utf8Value)
Parses with Ada
Allocates a new V8 string from href, even when it is byte-identical to the input

Typical URLs (https://example.com/path, the whatwg-url-parse benchmark corpus) are one-byte ASCII and already in serialized form. This change:

Parses one-byte ASCII inputs in place via v8::String::ValueView (no UTF-8 copy)
Returns the original V8 string when href == input (no second string allocation)
Avoids copying the base URL into a temporary std::string just to parse it
Applies the same in-place parse to update() (setters re-parse an already-serialized href)
Delays URLContext allocation until parse finishes, and initializes it in one shot from urlComponents
Skips `${input}` when the value is already a string

Non-ASCII inputs still go through Utf8Value. Those results are never reused as the original string, because UTF-8 conversion may replace unpaired surrogates.

Benchmark

Same machine, Release build, benchmark/url/whatwg-url-parse.js e=12. Repeated runs:

Config	Before (ops/s)	After (ops/s)	Change
`short` / no base	7.82M	9.29M	+19%
`long` / no base	2.50M	2.75M	+10%
`short` / with base	2.94M	3.39M	+15%

dot (needs path normalization, so a new href string) is unchanged.

Review follow-up

reuse_input defaults to nullptr. Base-URL parse and update() omit it so we skip the O(n) href == input compare when the original V8 string will not be reused.

Tests

test/parallel/test-whatwg-url-*.js and test-url-*.js: 54 pass, 1 skip
WPT url: 5107 pass, 0 unexpected failures
New test/parallel/test-whatwg-url-parse-fast-path.js covers already-serialized ASCII hrefs, trailing-slash and dot-segment normalization, base resolution, non-string input, invalid input, unpaired surrogates, IDN, and setters

Assisted-by: Cursor

nodejs-github-bot · 2026-08-18T01:12:24Z

Review requested:

@nodejs/url

codecov · 2026-08-18T02:49:02Z

Codecov Report

❌ Patch coverage is 97.08738% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (13fcd6f) to head (7589246).
⚠️ Report is 93 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_url.cc	93.18%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65361      +/-   ##
==========================================
- Coverage   91.85%   90.11%   -1.74%     
==========================================
  Files         400      752     +352     
  Lines      178855   252356   +73501     
  Branches    27319    47474   +20155     
==========================================
+ Hits       164283   227413   +63130     
- Misses      14243    16224    +1981     
- Partials      329     8719    +8390

Files with missing lines	Coverage Δ
lib/internal/url.js	`93.28% <100.00%> (+13.12%)`	⬆️
src/node_url.cc	`78.94% <93.18%> (ø)`

... and 490 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell

AI agents are not permitted to Signed-off-by

mcollina

lgtm

anonrig · 2026-08-18T11:40:10Z

Removed the Signed-off-by trailer from the commit(s). An AI agent cannot attest the DCO.

Parse one-byte ASCII inputs in place instead of copying them into a UTF-8 buffer, and reuse the original V8 string when the serialized href is unchanged. Delay URLContext allocation until parse finishes and skip ToString when the input is already a string. Signed-off-by: Yagiz Nizipli <[email protected]> Assisted-by: Cursor

gurgunday

I think we can avoid always comparing the strings here?

Base parsing and setters discard reuse_input, so here we can avoid an O(n) comparison no?

Resolved

mertcanaltin

LGTM, I think we can seperate PR same improvement for canParse?

Callers that never reuse the original V8 string (base URL parse and setters) now omit reuse_input so ParseUrlFromV8String does not compare href against the input. Signed-off-by: Yagiz Nizipli <[email protected]> Assisted-by: Cursor

mcollina

lgtm

nodejs-github-bot · 2026-08-21T10:37:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76112/

nodejs-github-bot · 2026-08-21T12:36:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76135/

nodejs-github-bot · 2026-08-21T15:56:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76163/

gurgunday

Lgtm

nodejs-github-bot · 2026-08-22T17:28:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76223/

nodejs-github-bot · 2026-08-22T18:36:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76236/

nodejs-github-bot · 2026-08-23T03:31:23Z

Landed in 2df4ce7...a8f9a7f

Parse one-byte ASCII inputs in place instead of copying them into a UTF-8 buffer, and reuse the original V8 string when the serialized href is unchanged. Delay URLContext allocation until parse finishes and skip ToString when the input is already a string. Signed-off-by: Yagiz Nizipli <[email protected]> Assisted-by: Cursor PR-URL: #65361 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Callers that never reuse the original V8 string (base URL parse and setters) now omit reuse_input so ParseUrlFromV8String does not compare href against the input. Signed-off-by: Yagiz Nizipli <[email protected]> Assisted-by: Cursor PR-URL: #65361 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>