Add Date::New overload for a std::chrono::system_clock::time_point#1705
Merged
Conversation
Contributor
Author
|
Not too sure how to add a unit test for this since it seems they're being done in JS |
Member
|
Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/date.cc and https://github.com/nodejs/node-addon-api/blob/main/test/date.js? Thank you! |
Contributor
Author
|
Added some basic unit test, |
legendecas
reviewed
Feb 26, 2026
KevinEady
requested changes
Feb 26, 2026
KevinEady
left a comment
Contributor
There was a problem hiding this comment.
Guards for c++11 can be removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 63.50% 63.56% +0.05%
==========================================
Files 3 3
Lines 2047 2053 +6
Branches 728 729 +1
==========================================
+ Hits 1300 1305 +5
Misses 162 162
- Partials 585 586 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Mar 23, 2026
KevinEady
approved these changes
Mar 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1704