Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alvarowolfx
Copy link
Contributor

Description

Our GCP Node SDK references the NodeJS releases page and as part of our CI, we check for broken links when generating documentation pages. With some recent changes, the link to nodejs.org/en/about/releases stopped working, which broke our CI pipeline.

Also, searching on Github, seems like multiple projects references the same page:

I've added the extra route in the next.rewrites.mjs file accordingly to PR #5580, which also reference the file https://github.com/nodejs/build/blob/f7e0f90a55b0c866041668e4285a16274f1e36f7/ansible/www-standalone/resources/config/nodejs.org?plain=1#L338. And we can see that /en/about/releases is indeed missing from the new rewrite logic.

Validation

Manual Testing that the Rewrites Work.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@alvarowolfx alvarowolfx requested a review from a team as a code owner July 31, 2023 15:53
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 3:54pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 3:54pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 15:54 Inactive
@alvarowolfx
Copy link
Contributor Author

@ovflowd seems like you've worked recently on this, so might be good to give a review on it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 15:54 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I had no idea GCP relies on an old page that no longer exists.

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 8.489s ⏱️

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ovflowd
Copy link
Member

ovflowd commented Jul 31, 2023

Fast Tracking as this is breaking GCP! cc @nodejs/website

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 31, 2023
@ovflowd ovflowd merged commit 9144b4f into nodejs:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants