Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: do not throw unhandled exception when data is undefined in interceptor.reply #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2025
Merged

fix: do not throw unhandled exception when data is undefined in interceptor.reply #4036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b694cc
fix: do not throw unhandled exception when data is undefined in inter…
frederikprijck Jan 31, 2025
08c4c24
Merge branch 'main' into main
metcoder95 Feb 4, 2025
490f73a
Merge branch 'nodejs:main' into main
frederikprijck Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/mock/mock-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,10 @@ function getResponseData (data) {
return data
} else if (typeof data === 'object') {
return JSON.stringify(data)
} else {
} else if (data) {
return data.toString()
} else {
return ''
}
}

Expand Down
40 changes: 40 additions & 0 deletions test/mock-interceptor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,46 @@ describe('MockInterceptor - reply options callback', () => {
})
})

test('should handle undefined data', t => {
t = tspl(t, { plan: 2 })

const mockInterceptor = new MockInterceptor({
path: '',
method: ''
}, [])
const result = mockInterceptor.reply((options) => ({
statusCode: 200,
data: undefined
}))
t.ok(result instanceof MockScope)

// Test parameters

const baseUrl = 'http://localhost:9999'
const mockAgent = new MockAgent()
after(() => mockAgent.close())

const mockPool = mockAgent.get(baseUrl)

mockPool.intercept({
path: '/test',
method: 'GET'
}).reply((options) => {
t.deepStrictEqual(options, { path: '/test', method: 'GET', headers: { foo: 'bar' } })
return { statusCode: 200, data: 'hello' }
})

mockPool.dispatch({
path: '/test',
method: 'GET',
headers: { foo: 'bar' }
}, {
onHeaders: () => { },
onData: () => { },
onComplete: () => { }
})
})

test('should error if passed options invalid', async (t) => {
t = tspl(t, { plan: 4 })

Expand Down
6 changes: 6 additions & 0 deletions test/mock-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ describe('getResponseData', () => {
const responseData = getResponseData(new TextEncoder().encode('{"test":true}').buffer)
t.ok(responseData instanceof ArrayBuffer)
})

test('it should handle undefined', (t) => {
t = tspl(t, { plan: 1 })
const responseData = getResponseData(undefined)
t.strictEqual(responseData, '')
})
})

test('getStatusText', (t) => {
Expand Down
Loading