Add support for daemon-mode Emacs. #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@somesoup any idea if this still works? |
|
For my setup this is still working (and required to get emacsclient to open). I'd be very happy if this could be merged. |
|
Does anyone know if this will go in at some point? Though there are not conflicts... |
|
Edit: Actually having looked a bit deeper this might cause problems, as daemonp doesn't necessarily mean high colour mode. Someone could use the daemon but still start their client in the console. So maybe time to close this off? Demo of what happens to console if you do use this technique:
|
aa83e0d to
5335a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the check for
display-graphic-pto includedaemonpso that colors get defined even when no frames are open in a display manager.