Adds Vim 8 terminal highlighting#126
Adds Vim 8 terminal highlighting#126arcticicestudio merged 1 commit intonordtheme:developfrom c9rgreen:develop
Conversation
|
@kooparse Can you confirm that you were running Vim 8 in iTerm using the |
|
In my env, Vim shows valid colors in terminal. Perhaps your vimrc makes a problem? my reproducible way
mkdir /tmp/nord-vim
cd /tmp/nord-vim
git clone https://github.com/cg433n/nord-vim
vim -N -u vimrc -i NONE
set runtimepath+=/tmp/nord-vim/nord-vim
colorscheme nord |
|
It is my config, we should merge it then 👍 |
|
I've tested with Vim 8 and iTerm and Terminal.app. Everything looks Ok. |
|
@cg433n Thanks for this PR and also everyone else involved for the feedback 👍 The changes looking good to me, I'll do a quick test on the weekend and merge it to get the next release version out asap. |
|
Hey @arcticicestudio, could this be merged? |
|
@jbadavis Sorry, this is one of the hundreds issues I've planned to review earlier, but sometimes real life keeps you busy. I'll set a reminder and will definitely do it this weekend. |
arcticicestudio
left a comment
There was a problem hiding this comment.
I've tested it with
- Vim v8.1 on macOS (Homebrew) and v8.1.0751-1 on Arch Linux
- NeoVim v0.3.4 on macOS (Homebrew) and Arch Linux
- MacVim v8.1-153 on macOS (Homebrew)
using a clean config and everything looks fine.
I'll merge it and if there are any problems or incompatibilities please open a new issue.
|
Hey @arcticicestudio, could this be merged? |
|
@sivakov512 I've reviewed the PR and requested some changes. It'll be merged as soon as the PR author resolved them. |
arcticicestudio
left a comment
There was a problem hiding this comment.
@cg433n Thanks for updating, but I've never used the "Suggested Changes" feature of GitHub so I've messed it up 😆
Fixed it again and force-pushed to merge.
Thanks again for your contribution 🚀
|
When using vim-plug the latest changes can be used by defining the |



Resolves #125