fix(button): Remove extra space caused by input type="file"#471
Closed
andreadellacorte wants to merge 1 commit intonostalgic-css:developfrom
Closed
fix(button): Remove extra space caused by input type="file"#471andreadellacorte wants to merge 1 commit intonostalgic-css:developfrom
andreadellacorte wants to merge 1 commit intonostalgic-css:developfrom
Conversation
Member
|
Thanks for the contribution! You'll need to update your commit message to comply with conventional commits before the checks will pass. Also, did you verify that the file input still works on all devices after making this change? From what I recall, the input is set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, elements have opacity: 0 rather than display: none - This is causing them to actually take space, causing an issue on mobile where the expands to the right.
This change fixes that.
Compatibility
No
Caveats
None