Not all send code samples change for the eu region #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GreyNewfie
commented
Feb 26, 2025
- Add optional base URL parameter to the SDK initialization
- Set base URL to the US by default
- Add region constants to easily and reliably set the region base URLs
- Add tests to ensure the correct endpoints are being set for each region
- Introduce optional base_url parameter in init() method - Add US_REGION import for default base URL - Update request() method to use dynamic base URL - Ensure backward compatibility with existing initialization
- Define constants for US, EU, and CA regions - Provide easy access to predefined base URLs for different geographical regions
- Create test suite for region initialization and URL selection - Test default, EU, CA, and custom region configurations - Verify correct base URL is used during API requests
- Import US_REGION constant in test file - Update API send path to use US_REGION base URL - Align test configuration with SDK region support
- Delete test case for initializing NotificationAPI with a custom URL to focus on initialization with regions
mbasadi
reviewed
Feb 26, 2025
Member
mbasadi
left a comment
There was a problem hiding this comment.
Check the node
we pass the actual url
ask Sahand ether we should change node SDK or this one
sahandseifi
approved these changes
Feb 26, 2025
Contributor
Author
|
@mbasadi Sahand wants me to update the Node SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.