fix(agents): address PR review comments

- Remove unused ChannelTypeEnum import from preview.usecase.ts - Enrich PATCH agent-runtime-config response with capabilities to match GET - Fail loudly in create-agent when adopt mode returns no agent name - Add guard in create-agent.usecase.ts: throw UnprocessableEntityException when runtime=managed but managedRuntime absent - Fix @type decorator in create-agent.command.ts to use ManagedRuntimeDto class for proper nested validation - Replace misleading NotFoundException with UnprocessableEntityException for missing apiKey in provision-managed-agent - Reject unknown MCP server IDs with BadRequestException instead of substituting empty URL - Fix update-agent-runtime-config to guard missing apiKey with UnprocessableEntityException instead of non-null assertion - Use public @novu/application-generic entry in e2e test instead of deep build path Co-authored-by: Cursor <[email protected]>
novuhq · djabarovgeorge · May 12, 2026 · May 10, 2026 · May 10, 2026 · May 11, 2026
commit 8c502f8f868eee9ffe1e6090911f29b8787ef397
diff --git a/apps/api/src/app/agents/e2e/managed-agent.e2e.ts b/apps/api/src/app/agents/e2e/managed-agent.e2e.ts
@@ -1,11 +1,11 @@
+import * as AgentRuntimeFactoryModule from '@novu/application-generic';
 import {
   AgentRuntimeBadRequestError,
   AgentRuntimeNotFoundError,
   AgentRuntimeRateLimitedError,
   AgentRuntimeUnauthorizedError,
   encryptCredentials,
 } from '@novu/application-generic';
-import * as AgentRuntimeFactoryModule from '@novu/application-generic/build/main/agent-runtimes/agent-runtime.factory';
 import { AgentRepository, IntegrationRepository } from '@novu/dal';
 import { AgentRuntimeProviderIdEnum, ChannelTypeEnum } from '@novu/shared';
 import { UserSession } from '@novu/testing';

diff --git a/apps/api/src/app/agents/usecases/create-agent/create-agent.command.ts b/apps/api/src/app/agents/usecases/create-agent/create-agent.command.ts
@@ -13,7 +13,7 @@ import {
 } from 'class-validator';
 
 import { EnvironmentWithUserCommand } from '../../../shared/commands/project.command';
-import type { ManagedRuntimeDto } from '../../dtos/agent-runtime-config.dto';
+import { ManagedRuntimeDto } from '../../dtos/agent-runtime-config.dto';
 
 export class CreateAgentCommand extends EnvironmentWithUserCommand {
   @ValidateIf((o) => !o.managedRuntime?.externalAgentId)
@@ -41,7 +41,7 @@ export class CreateAgentCommand extends EnvironmentWithUserCommand {
   @ValidateIf((o) => o.runtime === 'managed')
   @IsObject()
   @ValidateNested()
-  @Type(() => Object)
+  @Type(() => ManagedRuntimeDto)
   managedRuntime?: ManagedRuntimeDto;
 
   @IsOptional()

diff --git a/apps/api/src/app/agents/usecases/create-agent/create-agent.usecase.ts b/apps/api/src/app/agents/usecases/create-agent/create-agent.usecase.ts
@@ -1,4 +1,4 @@
-import { ConflictException, Injectable } from '@nestjs/common';
+import { ConflictException, Injectable, UnprocessableEntityException } from '@nestjs/common';
 import { AnalyticsService, shortId, slugifyOrRandom } from '@novu/application-generic';
 import { AgentRepository } from '@novu/dal';
 import { trackAgentCreated } from '../../agent-analytics';
@@ -40,7 +40,11 @@ export class CreateAgent {
       }
     }
 
-    const isManaged = command.runtime === 'managed' && command.managedRuntime;
+    if (command.runtime === 'managed' && !command.managedRuntime) {
+      throw new UnprocessableEntityException('managedRuntime is required when runtime is "managed".');
+    }
+
+    const isManaged = command.runtime === 'managed';
 
     const agent = isManaged
       ? await this.agentRepository.withTransaction(async (session) => {
@@ -86,6 +90,12 @@ export class CreateAgent {
               { session }
             );
 
+            if (isAdoptMode && !provisionResult.adoptedName) {
+              throw new Error(
+                `Provider returned no name for adopted agent "${command.managedRuntime?.externalAgentId}". Cannot resolve a unique identifier.`
+              );
+            }
+
             if (isAdoptMode && provisionResult.adoptedName) {
               // Resolve a unique identifier from the Claude agent name, following the
               // same pattern used elsewhere in the platform: slugify + random short ID on collision.

diff --git a/apps/api/src/app/agents/usecases/provision-managed-agent/provision-managed-agent.usecase.ts b/apps/api/src/app/agents/usecases/provision-managed-agent/provision-managed-agent.usecase.ts
@@ -1,4 +1,4 @@
-import { BadRequestException, Injectable, NotFoundException } from '@nestjs/common';
+import { BadRequestException, Injectable, NotFoundException, UnprocessableEntityException } from '@nestjs/common';
 import {
   decryptCredentials,
   encryptCredentials,
@@ -125,7 +125,9 @@ export class ProvisionManagedAgent {
       const decryptedCredentials = decryptCredentials(integration.credentials);
 
       if (!decryptedCredentials.apiKey) {
-        throw new NotFoundException(`Integration "${command.integrationId}" has no API key configured.`);
+        throw new UnprocessableEntityException(
+          `Integration "${command.integrationId}" has no API key configured. Please complete the integration setup.`
+        );
       }
 
       resolvedIntegrationId = integration._id;
@@ -155,7 +157,13 @@ export class ProvisionManagedAgent {
         const resolvedMcpServers = command.mcpServers?.map((serverId) => {
           const catalogServer = CLAUDE_MCP_SERVERS.find((s) => s.id === serverId);
 
-          return { name: catalogServer?.name ?? serverId, url: catalogServer?.url ?? '' };
+          if (!catalogServer) {
+            throw new BadRequestException(
+              `Unknown MCP server ID "${serverId}". Must be one of the supported catalog entries.`
+            );
+          }
+
+          return { name: catalogServer.name, url: catalogServer.url };
         });
 
         const response = await runtimeProvider.createAgent({

diff --git a/...rc/app/agents/usecases/update-agent-runtime-config/update-agent-runtime-config.usecase.ts b/...rc/app/agents/usecases/update-agent-runtime-config/update-agent-runtime-config.usecase.ts
@@ -1,7 +1,8 @@
 import { Injectable, NotFoundException, UnprocessableEntityException } from '@nestjs/common';
 import { decryptCredentials, getAgentRuntimeProvider } from '@novu/application-generic';
 import { AgentRepository, IntegrationRepository } from '@novu/dal';
-import { AgentRuntimeConfigResponseDto } from '../../dtos/agent-runtime-config.dto';
+import { AGENT_RUNTIME_PROVIDERS } from '@novu/shared';
+import type { AgentRuntimeCapabilitiesDto, AgentRuntimeConfigResponseDto } from '../../dtos/agent-runtime-config.dto';
 import { UpdateAgentRuntimeConfigCommand } from './update-agent-runtime-config.command';
 
 @Injectable()
@@ -45,7 +46,14 @@ export class UpdateAgentRuntimeConfig {
     }
 
     const decryptedCredentials = decryptCredentials(integration.credentials);
-    const runtimeProvider = getAgentRuntimeProvider(providerId, decryptedCredentials.apiKey!);
+
+    if (!decryptedCredentials.apiKey) {
+      throw new UnprocessableEntityException(
+        `Integration for agent "${command.identifier}" has no API key configured. Please complete the integration setup.`
+      );
+    }
+
+    const runtimeProvider = getAgentRuntimeProvider(providerId, decryptedCredentials.apiKey);
 
     const updated = await runtimeProvider.updateConfig(externalAgentId, {
       model: command.model,
@@ -55,12 +63,25 @@ export class UpdateAgentRuntimeConfig {
       skills: command.skills,
     });
 
+    const providerEntry = AGENT_RUNTIME_PROVIDERS.find((p) => p.providerId === providerId);
+
+    const capabilities: AgentRuntimeCapabilitiesDto | undefined = providerEntry
+      ? {
+          mcpServers: providerEntry.capabilities.mcpServers,
+          tools: providerEntry.capabilities.tools,
+          model: providerEntry.capabilities.model,
+          systemPrompt: providerEntry.capabilities.systemPrompt,
+          skills: providerEntry.capabilities.skills,
+        }
+      : undefined;
+
     const result: AgentRuntimeConfigResponseDto = {
       model: updated.model,
       systemPrompt: updated.systemPrompt,
       mcpServers: updated.mcpServers,
       tools: updated.tools,
       ...(updated.skills !== undefined ? { skills: updated.skills } : {}),
+      ...(capabilities !== undefined ? { capabilities } : {}),
     };
 
     return result;

diff --git a/libs/application-generic/src/usecases/preview/preview.usecase.ts b/libs/application-generic/src/usecases/preview/preview.usecase.ts
@@ -2,7 +2,6 @@ import { Injectable } from '@nestjs/common';
 import { EnvironmentRepository, EnvironmentVariableRepository } from '@novu/dal';
 import { ContextResolved } from '@novu/framework/internal';
 import {
-  ChannelTypeEnum,
   EnvironmentSystemVariables,
   NotificationChannelTypeEnum,
   ResourceOriginEnum,