Fix test timeout_during_authentication#6388
Conversation
roji
left a comment
There was a problem hiding this comment.
Just checking: don't we need to pass --blame-hang (and maybe --blame, --blame-crash) for dotnet test above in order to produce these files?
|
|
||
| - name: Upload Hang Dumps | ||
| uses: actions/upload-artifact@v6 | ||
| if: always() |
There was a problem hiding this comment.
It's kinda funny. Google's LLM said that yes, it's required. Checking again it now says that it should be failure() instead of always(). But anyway yes, we do have to have that if as otherwise we'll skip this step.
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} test/Npgsql.DependencyInjection.Tests --logger "GitHubActions;report-warnings=false" | ||
| shell: bash | ||
|
|
||
| - name: Upload Hang Dumps |
There was a problem hiding this comment.
| - name: Upload Hang Dumps | |
| - name: Upload Test Hang Dumps |
Already have it. npgsql/.github/workflows/build.yml Lines 302 to 304 in 7751d2e We can also add |
(cherry picked from commit 8cf2fa6)
No description provided.