Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: arborist fund cmd refactor #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: arborist fund cmd refactor #1311

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented May 15, 2020 •
edited
Loading

Changes:

  • npm fund cmd:
    • no longer depends on lib/install modules
    • now it uses arborist tree and inventory to retrieve funding data
    • refactor to use same exports patterns to new commands
    • changed human output to reinstate representation of nested deps
  • install:
    • no longer breaks on missing audit report
    • refactored reify-output to use libnpmfund module
    • added tests for utils.reify-output fund summary
  • moved logic from lib/utils/funding.js into a new libnpmfund pkg

@ruyadorno ruyadorno requested a review from a team as a code owner May 15, 2020 21:45
@ruyadorno
Copy link
Contributor Author

I had a quick chat with @isaacs related to this and I'd actually like to pluck out lib/utils/funding.js into a lib of its own, like @npmcli/funding or something

@darcyclarke darcyclarke added this to the OSS - Sprint 8 milestone Jun 1, 2020
@darcyclarke darcyclarke added Enhancement new feature or improvement Release 7.x work is associated with a specific npm 7 release labels Jun 1, 2020
@ruyadorno ruyadorno force-pushed the ruyadorno/npm-fund-v7 branch from c67ee3b to 4d28bee Compare June 4, 2020 21:10
isaacs
isaacs previously requested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some stuff that's a little confusing. Maybe we can find some time tomorrow to sync up on this? May well be I'm just misunderstanding exactly what fund is doing.

@ruyadorno ruyadorno dismissed isaacs’s stale review June 8, 2020 18:53

we went over some of the concerns in a pair session, I'll still get to some of the comments here but otherwise it should be good to merge

This was referenced Jun 10, 2020
Closed
Closed
@ruyadorno ruyadorno force-pushed the ruyadorno/npm-fund-v7 branch from e0d621d to 050ddf7 Compare June 11, 2020 21:54
@ruyadorno
Copy link
Contributor Author

adressed all items from original @isaacs review 😊

should be good to merge ✅

@ruyadorno
chore: arborist fund cmd refactor
7e908c2 
- npm fund cmd:
  - no longer depends on `lib/install` modules
  - now it uses arborist tree and inventory to retrieve funding data
  - refactor to use same exports patterns to new commands
  - changed human output to reinstate representation of nested deps
- install:
  - no longer breaks on missing audit report
  - refactored `reify-output` to use `libnpmfund` module
  - added tests for utils.reify-output fund summary
- moved logic from `lib/utils/funding.js` into a new `libnpmfund` pkg
@ruyadorno ruyadorno force-pushed the ruyadorno/npm-fund-v7 branch from 050ddf7 to 7e908c2 Compare June 12, 2020 17:49
darcyclarke
darcyclarke approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

ruyadorno added a commit that referenced this pull request Jun 12, 2020
@ruyadorno
chore: arborist fund cmd refactor
a16f172 
- npm fund cmd:
  - no longer depends on `lib/install` modules
  - now it uses arborist tree and inventory to retrieve funding data
  - refactor to use same exports patterns to new commands
  - changed human output to reinstate representation of nested deps
- install:
  - no longer breaks on missing audit report
  - refactored `reify-output` to use `libnpmfund` module
  - added tests for utils.reify-output fund summary
- moved logic from `lib/utils/funding.js` into a new `libnpmfund` pkg

PR-URL: #1311
Credit: @ruyadorno
Close: #1311
Reviewed-by: @darcyclarke
@ruyadorno ruyadorno closed this Jun 12, 2020
@nlf nlf deleted the ruyadorno/npm-fund-v7 branch March 28, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@isaacs isaacs isaacs left review comments

@darcyclarke darcyclarke darcyclarke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ruyadorno ruyadorno

Labels
Enhancement new feature or improvement Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 8
Development

Successfully merging this pull request may close these issues.
3 participants
@ruyadorno @isaacs @darcyclarke