Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(perf): enable compile cache #7901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(perf): enable compile cache #7901

merged 1 commit into from
Nov 20, 2024

Conversation

H4ad
Copy link
Contributor

@H4ad H4ad commented Nov 10, 2024 •
edited
Loading

Adding support to module.enableCompileCache, added by nodejs/node#54501, Typescript got 2.5x perf on tsc.

On my machine, for the command --version, I got the following results:

Benchmark 1: node bin/npm-cli.js --version
  Time (mean ± σ):      58.0 ms ±   1.1 ms    [User: 51.8 ms, System: 16.8 ms]
  Range (min … max):    56.5 ms …  62.6 ms    51 runs
 
Benchmark 2: node bin/npm-cli-with-cache.js --version
  Time (mean ± σ):      52.9 ms ±   1.0 ms    [User: 46.5 ms, System: 16.8 ms]
  Range (min … max):    51.4 ms …  55.5 ms    56 runs
 
Summary
  'node bin/npm-cli-with-cache.js --version' ran
    1.10 ± 0.03 times faster than 'node bin/npm-cli.js --version'

I run the same test with npm run empty and I got the same 10% improvement.

@H4ad H4ad requested a review from a team as a code owner November 10, 2024 02:07
H4ad
H4ad commented Nov 10, 2024
View reviewed changes
@wraithgar
Copy link
Member

Thanks! If you want to duplicate this PR in the release/v10 branch it could go out w/ the imminent v10 release.

@H4ad H4ad mentioned this pull request Nov 20, 2024
Merged
@H4ad
Copy link
Contributor Author

H4ad commented Nov 20, 2024

Sure, #7924

@wraithgar wraithgar merged commit e19bff0 into npm:latest Nov 20, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H4ad @wraithgar