Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: splits out smoke-tests from publish-dryrun tests #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2025
Merged

chore: splits out smoke-tests from publish-dryrun tests #8069

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abfbc75
fix smokes
reggi Jan 28, 2025
fab233d
fix run
reggi Jan 28, 2025
4ab57e5
undo package changes
reggi Jan 28, 2025
e35c62b
use hbs template
reggi Jan 28, 2025
9d4a123
chore: run smoke tests and publish dryrun on pr
reggi Jan 28, 2025
ade331d
removes matrix, and publish dry-run
reggi Jan 28, 2025
f5d401a
fix script put back matrix for release only
reggi Jan 28, 2025
cbc895f
fix names
reggi Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removes matrix, and publish dry-run
  • Loading branch information
@reggi
reggi committed Jan 28, 2025
commit ade331d7eca7db0d5c69ce3995b95294b1b129c6
50 changes: 13 additions & 37 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,12 @@ jobs:
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
name: Smoke Publish
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
matrix:
platform:
- name: Linux
os: ubuntu-latest
shell: bash
node-version:
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
runs-on: ubuntu-latest
defaults:
run:
shell: ${{ matrix.platform.shell }}
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -182,15 +170,15 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
uses: actions/setup-node@v4
id: node
with:
node-version: ${{ matrix.node-version }}
check-latest: contains(matrix.node-version, '.x')
node-version: 22.x
check-latest: contains('22.x', '.x')
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand All @@ -211,24 +199,12 @@ jobs:
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
name: Smoke Publish
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
matrix:
platform:
- name: Linux
os: ubuntu-latest
shell: bash
node-version:
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
runs-on: ubuntu-latest
defaults:
run:
shell: ${{ matrix.platform.shell }}
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -243,22 +219,22 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
uses: actions/setup-node@v4
id: node
with:
node-version: ${{ matrix.node-version }}
check-latest: contains(matrix.node-version, '.x')
node-version: 22.x
check-latest: contains('22.x', '.x')
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
run: node ./publish.js --pack-destination=$RUNNER_TEMP --smoke-publish=true
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
Expand Down
50 changes: 13 additions & 37 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,24 +151,12 @@ jobs:
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
name: Smoke Publish
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
matrix:
platform:
- name: Linux
os: ubuntu-latest
shell: bash
node-version:
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
runs-on: ubuntu-latest
defaults:
run:
shell: ${{ matrix.platform.shell }}
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -183,15 +171,15 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
uses: actions/setup-node@v4
id: node
with:
node-version: ${{ matrix.node-version }}
check-latest: contains(matrix.node-version, '.x')
node-version: 22.x
check-latest: contains('22.x', '.x')
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
Expand All @@ -212,24 +200,12 @@ jobs:
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
name: Smoke Publish
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
matrix:
platform:
- name: Linux
os: ubuntu-latest
shell: bash
node-version:
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
runs-on: ubuntu-latest
defaults:
run:
shell: ${{ matrix.platform.shell }}
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -244,22 +220,22 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
uses: actions/setup-node@v4
id: node
with:
node-version: ${{ matrix.node-version }}
check-latest: contains(matrix.node-version, '.x')
node-version: 22.x
check-latest: contains('22.x', '.x')
cache: npm
- name: Check Git Status
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
run: node ./publish.js --pack-destination=$RUNNER_TEMP --smoke-publish=true
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
Expand Down
82 changes: 0 additions & 82 deletions scripts/publish-dryrun.sh
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions scripts/template-oss/ci-release-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
{{> jobYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
Expand All @@ -27,15 +27,15 @@
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
{{> jobYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
run: node ./publish.js --pack-destination=$RUNNER_TEMP --smoke-publish=true
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
Expand Down
6 changes: 3 additions & 3 deletions scripts/template-oss/ci-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
{{> jobYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
Expand All @@ -32,15 +32,15 @@
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
{{> jobYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
run: node ./publish.js --pack-destination=$RUNNER_TEMP --smoke-publish=true
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
Expand Down
Loading