Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
865070c
Settle overrides conflicts between edges, and propagate changes to th…
AlonNavon Nov 23, 2023
cd20196
cleanup
AlonNavon Nov 26, 2023
0cad4e0
Optimization
AlonNavon Nov 26, 2023
6b276f3
Fix override sets comparisons
AlonNavon Nov 28, 2023
fff3072
Add comparator
AlonNavon Nov 28, 2023
e97176e
Check for undefined
AlonNavon Nov 28, 2023
19155ed
Another place
AlonNavon Nov 28, 2023
dedbccf
Fix
AlonNavon Nov 28, 2023
4a83786
Lint fixes
AlonNavon Dec 6, 2023
7ee2f2e
Added tests
AlonNavon Dec 6, 2023
0917421
Overrides aren't inherited from parent, but from to nodes
AlonNavon Oct 27, 2024
6d0ad42
Always use raw spec when analyzing overrides
AlonNavon Oct 28, 2024
67d7d5c
Replaceability
AlonNavon Oct 28, 2024
643cbea
Overridden status
AlonNavon Oct 28, 2024
c5f6e4a
Fix undefined bugs
AlonNavon Oct 28, 2024
6c9bbf9
Parent doesn't matter to overrides
AlonNavon Oct 28, 2024
63760d9
Update override set in reload
AlonNavon Oct 28, 2024
6111630
Erroneous node
AlonNavon Oct 28, 2024
b42d4c8
Add comments
AlonNavon Oct 29, 2024
7d97726
Code review fixes
AlonNavon Nov 4, 2024
35e5790
Fix edge satisfaction logic
AlonNavon Nov 4, 2024
35ce2f7
Fix dedupe logic
AlonNavon Nov 4, 2024
5630954
Code review fixes
AlonNavon Nov 4, 2024
f859e92
Oops
AlonNavon Nov 4, 2024
29f0750
Static function
AlonNavon Nov 5, 2024
17ec457
Typo
AlonNavon Nov 5, 2024
4cde831
Shouldn't throw
AlonNavon Nov 7, 2024
701b125
CR fixes
AlonNavon Nov 7, 2024
b119f67
CR fixes
AlonNavon Nov 7, 2024
3136b64
Move functions
AlonNavon Nov 10, 2024
80126c7
Comments
AlonNavon Nov 11, 2024
c4b5338
Override sets unit tests
AlonNavon Nov 11, 2024
9db1232
Clarify comment
AlonNavon Nov 11, 2024
3ba9932
linter
owlstronaut Feb 7, 2025
d1b0b40
linter
owlstronaut Feb 7, 2025
3e72626
linter
owlstronaut Feb 7, 2025
1ae3573
findSpecificOverrideSet is meant to evaluate between a overrideset hi…
owlstronaut Feb 7, 2025
eee425a
see about stubbing silly
owlstronaut Feb 7, 2025
62a2598
fix import
owlstronaut Feb 7, 2025
799bca4
fallback to spec if rawSpec is undefined
owlstronaut Feb 7, 2025
7867d4f
Adjust test for behavior change
owlstronaut Feb 10, 2025
41b1b10
add unit test for override-set
owlstronaut Feb 10, 2025
331bd9b
Add test coverage for node.js
owlstronaut Feb 10, 2025
625f597
Merge remote-tracking branch 'origin/latest' into owlstronaut/fix-ove…
owlstronaut Feb 10, 2025
bf6a6e1
log in tests fixed, code coverage fix
owlstronaut Feb 10, 2025
fb45900
fix: guard against updating edges of `undefined`
owlstronaut Feb 14, 2025
1035784
chore: verify override does not apply when version mismatches. Add te…
owlstronaut Feb 19, 2025
a2a1cc6
fix: ensure cycles are respected
owlstronaut Feb 20, 2025
dc97dd1
fix: resolve coverage for unused code paths
owlstronaut Feb 20, 2025
9ac2649
chore: add test coverage for override propagation and setting 'INVALI…
owlstronaut Feb 20, 2025
d453f13
chore: node.js test actually tests value override
owlstronaut Feb 20, 2025
f32a8dd
chore: clean up unnecessary comments
owlstronaut Feb 20, 2025
9feb44c
fix: fixes incorrect use of log.silly
owlstronaut Feb 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parent doesn't matter to overrides
  • Loading branch information
AlonNavon committed Oct 28, 2024
commit 6c9bbf9a51743a5897d0240431fd78438605fb35
3 changes: 0 additions & 3 deletions workspaces/arborist/lib/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -837,9 +837,6 @@ class Node {
target.root = root
}

if (!this.overrides && this.parent && this.parent.overrides) {
this.overrides = this.parent.overrides.getNodeRule(this)
}
// tree should always be valid upon root setter completion.
treeCheck(this)
if (this !== root) {
Expand Down