Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating #8535
npm install --omit
output doesn't show any removed packages.This PR moves the omit calc into the diff calc so omits are handled like other resolution logic.
Improvements:
I removed the trashList check on reifying node. Code coverage complained that this branch wasn't hit in any tests so I assume it should always be empty.
I think this uncovered one bug with workspaces in the test
workspaces > reify workspaces omit dev dependencies > workspaces only
. From my understanding of the docs, only workspacea
should be touched,root
and workspaceb
should still have their packages. I updated the test.