This repository was archived by the owner on Nov 4, 2022. It is now read-only.
also use the copy fallback for EPERM errors #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Feb 10, 2021
wraithgar
approved these changes
Feb 11, 2021
PR-URL: #5 Credit: @nlf Close: #5 Reviewed-by: @wraithgar
b0dbfbc to
0388f6a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in windows we're currently seeing the rename syscall throw EPERM in some cases, if this happens then we can fallback to the mdkir and copy approach. if the user genuinely does not have permissions, the mkdirp call or the first copyFile call will also fail with an EPERM which goes uncaught
will add tests before this lands
References