Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: update tap + fix tests #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: update tap + fix tests #426

wants to merge 1 commit into from

Conversation

louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Jan 28, 2022 •
edited
Loading

I had the following error when running npm test

> [email protected] test
> tap

TypeError: Cannot read properties of undefined (reading 'getFileName')
    at module.exports (node-semver\node_modules\tap\node_modules\caller-path\index.js:4:40) 
    at importJSX (node-semver\node_modules\tap\node_modules\import-jsx\index.js:24:46)      
    at module.exports (node-semver\node_modules\tap\node_modules\treport\lib\index.js:13:18)
    at exports.makeReporter (node-semver\node_modules\tap\bin\run.js:422:23)
    at runTests (node-semver\node_modules\tap\bin\run.js:744:3)
    at mainAsync (node-semver\node_modules\tap\bin\run.js:244:5)
TAP version 13
1..0
# time=1.581ms

Updating tap allowed the to run but failed on test/functions/coerce.js:

 FAIL ​ test/functions/coerce.js 1 failed of 93 43.195ms
 ✖ t.done is not a function

I replaced t.done with t.end, which, as far as I can tell, is used everywhere else.

The test run was then fully green.

References

Related to #401 - Actually the same, just with a more recent version

@louis-bompart
test: update tap + fix tests
563d75e 
 - Updated tap
 - Replaced sole occurence of `tap.done()` by `tap.end()`
@louis-bompart louis-bompart mentioned this pull request Jan 28, 2022
Merged
@lukekarrys lukekarrys mentioned this pull request Feb 26, 2022
Merged
@lukekarrys
Copy link
Contributor

Closing in favor of #433

@lukekarrys lukekarrys closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @lukekarrys