This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Parallelize tarball extraction #16633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
210b10b to
33a2155
Compare
f4b6a2c to
db76632
Compare
d24e332 to
b86d2db
Compare
86ea531 to
4d2a74d
Compare
097b5c8 to
63c61a6
Compare
rmg
reviewed
Jun 6, 2017
lib/install/action/extract-worker.js
Outdated
| opts.log = npmlog | ||
| opts.log.level = opts.loglevel | ||
| } | ||
| extract(spec, extractTo, opts).nodeify(cb) |
There was a problem hiding this comment.
extract here may be returning a "vanilla" Promise from https://www.npmjs.com/package/promise-retry which is not a Bluebird promise, so it won't have a nodeify method.
This is spewing out all over the place with the current canary version (5.0.2-canary.10) which appears to have this code in it.
/Users/ryan/.nvs/node/8.0.0/x64/lib/node_modules/npmc/lib/install/action/extract-worker.js:15
extract(spec, extractTo, opts).nodeify(cb)
^
TypeError: extract(...).nodeify is not a function
at module.exports (/Users/ryan/.nvs/node/8.0.0/x64/lib/node_modules/npmc/lib/install/action/extract-worker.js:15:34)
at handle (/Users/ryan/.nvs/node/8.0.0/x64/lib/node_modules/npmc/node_modules/worker-farm/lib/child/index.js:41:8)
at process.<anonymous> (/Users/ryan/.nvs/node/8.0.0/x64/lib/node_modules/npmc/node_modules/worker-farm/lib/child/index.js:47:3)
at emitTwo (events.js:125:13)
at process.emit (events.js:213:7)
at process.nextTick (internal/child_process.js:755:12)
at _combinedTickCallback (internal/process/next_tick.js:95:7)
at process._tickCallback (internal/process/next_tick.js:161:9)
There was a problem hiding this comment.
oop. Well, that's fun. Thanks for catching this. :)
|
@rmg I've pushed a change to wrap it in a bluebird promise, and I've made a patch over in pacote to also make sure we return a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.