This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Warn if running npm build without args and with a build script
#17351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user mistakenly shorthands `npm build` for `npm run build` then they currently get no output or information since `npm build` without arguments is a no-op. If `npm build` is called without arguments when a `build` script is defined in the package.json `scripts` section then output a warning message to indicate this. See npm#3927
|
Thanks! This would definitely save folks a lotta trouble. It's been merged as 82df7bb. |
iarna
pushed a commit
that referenced
this pull request
Jun 27, 2017
If a user mistakenly shorthands `npm build` for `npm run build` then they currently get no output or information since `npm build` without arguments is a no-op. If `npm build` is called without arguments when a `build` script is defined in the package.json `scripts` section then output a warning message to indicate this. Fixes: #3927 PR-URL: #17351 Credit: @lennym Reviewed-By: @iarna
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user mistakenly shorthands
npm buildfornpm run buildthen they currently get no output or information sincenpm buildwithout arguments is a no-op.If
npm buildis called without arguments when abuildscript is defined in the package.jsonscriptssection then output a warning message to indicate this.See #3927