Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Fix spurious removal reporting #17591

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Fix spurious removal reporting #17591

merged 2 commits into from
Jul 4, 2017

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Jul 3, 2017

Previously, if you asked to remove something that wasn't in your node_modules and wasn't in your package.json (or you didn't have a package.json) we would still report that we removed something even though there was no work for us to do.

@iarna iarna force-pushed the iarna/fix-report-rm-no-pkgjs branch from 6d5cc2c to e699515 Compare July 3, 2017 21:43
@iarna iarna force-pushed the iarna/fix-report-rm-no-pkgjs branch 2 times, most recently from 75a0cf6 to 25d1714 Compare July 3, 2017 22:09
zkat
zkat approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐑 🚀

zkat
zkat approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zkat zkat merged commit 20834fb into release-next Jul 4, 2017
@zkat zkat deleted the iarna/fix-report-rm-no-pkgjs branch July 4, 2017 01:17
zkat pushed a commit that referenced this pull request Jul 5, 2017
@iarna @zkat
install: fix spurious removal reporting (#17591)
9b2a098 
* install: Fix reporting of removals w/o package.json
* install: Fix reporting of removals of non-existant things w/pjson

PR-URL: #17591
Credit: @iarna
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Jul 5, 2017
@iarna @zkat
install: fix spurious removal reporting (#17591)
06ba0a1 
* install: Fix reporting of removals w/o package.json
* install: Fix reporting of removals of non-existant things w/pjson

PR-URL: #17591
Credit: @iarna
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iarna @zkat