fix: use URL.canParse instead of runtime deprecated url.parse api
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9036160 to
3503682
Compare
3503682 to
2e9de94
Compare
wraithgar
reviewed
Jul 22, 2025
wraithgar
approved these changes
Jul 22, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Aug 28, 2025
🤖 I have created a release *beep* *boop* --- ## [7.0.0](v6.2.0...v7.0.0) (2025-07-25) ###⚠️ BREAKING CHANGES * `package-json` now supports node `^20.17.0 || >=22.9.0` ### Features * [`9dd0eb5`](9dd0eb5) [#144](#144) add syncNormalize (@wraithgar) * [`08eae47`](08eae47) [#144](#144) add binDir step to normalize function (@wraithgar) ### Bug Fixes * [`a5e4ac3`](a5e4ac3) [#152](#152) align to npm 11 node engine range (@owlstronaut) * [`4695e87`](4695e87) [#150](#150) use `URL.canParse` instead of runtime deprecated `url.parse` api (#150) (@SuperchupuDev) * [`dbc9ef1`](dbc9ef1) [#144](#144) require an object in fromContent() (@wraithgar) * [`f06eb18`](f06eb18) [#144](#144) remove unused bundleDependenciesFalse (@wraithgar) * [`a8b1cc9`](a8b1cc9) [#144](#144) secure and unixify paths discovered via directories.bin (@wraithgar) * [`23c29a9`](23c29a9) [#144](#144) remove erroneous bundledDependencies log (@wraithgar) ### Documentation * [`14f8141`](14f8141) [#147](#147) adding sort option docs to README (#147) (@idhard) ### Dependencies * [`a0dcfde`](a0dcfde) [#152](#152) `[email protected]` * [`41128c1`](41128c1) [#152](#152) `[email protected]` ### Chores * [`a179a87`](a179a87) [#144](#144) fix tests to await async normalize (@wraithgar) * [`203fec8`](203fec8) [#144](#144) remove read-package-json (@wraithgar) * [`7bde184`](7bde184) [#144](#144) remove read-package-json-fast (@wraithgar) * [`394192d`](394192d) [#144](#144) remove backward compatiblity tests (@wraithgar) * [`6e89e39`](6e89e39) [#148](#148) bump @npmcli/template-oss from 4.23.6 to 4.25.0 (#148) (@dependabot[bot], @owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.parseis runtime deprecated. It looks like it's being used here to somewhat check if the string is a valid URL, so I've changed that toURL.canParsewhich is the compliant way of checking whether a string is a valid and parsable URL.URL.canParsewas added in node18.17.0and19.9.0I've backported this to
normalize-package-data: npm/normalize-package-data#247References
npm/normalize-package-data#242
pnpm/pnpm#9529
https://developer.mozilla.org/en-US/docs/Web/API/URL/canParse_static
https://nodejs.org/api/url.html#urlcanparseinput-base